Fix target_info metric name in PrometheusHttpServerBuilder javadoc#8628
Draft
thswlsqls wants to merge 1 commit into
Draft
Fix target_info metric name in PrometheusHttpServerBuilder javadoc#8628thswlsqls wants to merge 1 commit into
thswlsqls wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8628 +/- ##
=========================================
Coverage 91.60% 91.60%
Complexity 10343 10343
=========================================
Files 1013 1013
Lines 27352 27352
Branches 3215 3215
=========================================
Hits 25057 25057
Misses 1567 1567
Partials 728 728 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No issue: trivial javadoc typo, submitting directly.
Description
PrometheusHttpServerBuilder.setTargetInfoMetricEnableddocuments the metric asotel_target_info, but the exported name istarget_info.Otel2PrometheusConverter.makeTargetInfo()hardcodesMetricMetadata.builder().name("target"), which the Prometheus client exposes astarget_info; no code path adds anotel_prefix.PrometheusMetricReaderBuilder.setTargetInfoMetricEnabled, which this method delegates to, already documents it astarget_info.target_info.Testing done
target_infooutput../gradlew :exporters:prometheus:check— 202 tests + 1 testJpms test passed.exporters/prometheusis alpha (not tracked by japicmp) and nothing user-facing changes.