Skip empty baggage key in OtTracePropagator extract#8631
Draft
thswlsqls wants to merge 1 commit into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8631 +/- ##
=========================================
Coverage 91.60% 91.60%
- Complexity 10343 10344 +1
=========================================
Files 1013 1013
Lines 27352 27353 +1
Branches 3215 3216 +1
=========================================
+ Hits 25057 25058 +1
Misses 1567 1567
Partials 728 728 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8629
Description
OtTracePropagator.extract()only checkedstartsWith(PREFIX_BAGGAGE_HEADER), so a header named exactlyot-baggage-produced a baggage entry keyed"".inject()re-emits it, and it consumes one of the 64 baggage entries.JaegerPropagator.getBaggageFromHeader()and itsextract_baggageOnly_withPrefix_emptyKeytest in the same package.W3CBaggagePropagator.isValidBaggageKey()rejects it, and theImmutableKeyValuePairsJavadoc makes removing empty keys the caller's responsibility.ot-baggage-<key>headers, byte accounting, and limits are unchanged.Testing done
OtTracePropagatorTest#extract_Baggage_EmptyKey, assertingBaggage.empty()for a valid span context plus anot-baggage-header../gradlew :extensions:trace-propagators:check --rerun-tasks— 132 tests passed.*ITand GraalVM native-image tests were not run locally.