Add links to OpenCensus spans after span start#8635
Draft
thswlsqls wants to merge 1 commit into
Draft
Conversation
thswlsqls
force-pushed
the
fix/opencensus-shim-add-link
branch
from
July 17, 2026 06:27
a6d909e to
0982385
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8635 +/- ##
============================================
+ Coverage 91.64% 91.65% +0.01%
- Complexity 10348 10349 +1
============================================
Files 1013 1013
Lines 27380 27389 +9
Branches 3218 3218
============================================
+ Hits 25092 25103 +11
+ Misses 1558 1556 -2
Partials 730 730 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
thswlsqls
force-pushed
the
fix/opencensus-shim-add-link
branch
from
July 18, 2026 01:00
0982385 to
e6f64e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6589
Description
OpenTelemetrySpanImpl.addLink(Link)logged a warning and dropped the link. It now converts theOpenCensus link and forwards it to the OpenTelemetry span.
Span#addLink, added in 1.37.0, so its premise no longer holds.addAnnotationandaddMessageEventalready delegate;addLinkwas the only one thatdid not.
getDelegate().addLink(..), notDelegatingSpan.super.addLink(..), which would resolve tothe no-op default method on
Span.Link.getType()is dropped — no OpenTelemetry equivalent, andOpenTelemetrySpanBuilderImplignores link type too.
Testing done
OpenTelemetrySpanImplTest#addLink_delegatesToOtelSpanand#addLink_mapsAttributes,asserting trace ID, span ID and attributes reach
Span#addLink(SpanContext, Attributes). Bothfail without the fix.
./gradlew :opencensus-shim:check— 63 tests passed.### ShimsCHANGELOG entry.