Skip to content

Avoid unsafe string encoder on Android #8637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
trask wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −0
Open

Avoid unsafe string encoder on Android #8637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .../common/src/main/java/io/opentelemetry/exporter/internal/marshal/StringEncoderHolder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,12 @@ public static StringEncoder createFallbackEncoder() {
*/
@Nullable
public static StringEncoder createUnsafeEncoder() {
// Android exposes sun.misc.Unsafe, but String does not have the OpenJDK internal fields used by
// UnsafeStringEncoder. ART logs an error when these missing fields are queried, even though the
// exception is caught.
if ("Dalvik".equals(System.getProperty("java.vm.name"))) {
return null;
}
Comment on lines +42 to +47

@trask trask Jul 17, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was torn between adding the check here or in UnsafeStringEncoder.createIfAvailable(). Happy to move if you have a preference.

return UnsafeStringEncoder.createIfAvailable();
}

Expand Down
7 changes: 7 additions & 0 deletions ...rs/common/src/test/java/io/opentelemetry/exporter/internal/marshal/StringEncoderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.condition.DisabledOnJre;
import org.junit.jupiter.api.condition.JRE;
import org.junitpioneer.jupiter.SetSystemProperty;

class StringEncoderTest {

Expand Down Expand Up @@ -57,6 +58,12 @@ void testUtf8SizeLatin1_VarHandle() {
testUtf8SizeLatin1(varHandleStringEncoder);
}

@Test
@SetSystemProperty(key = "java.vm.name", value = "Dalvik")
void unsafeStringEncoderNotAvailableOnAndroid() {
assertThat(StringEncoderHolder.createUnsafeEncoder()).isNull();
}

@SuppressWarnings("AvoidEscapedUnicodeCharacters")
private static void testUtf8Encoding(StringEncoder stringEncoder) {
assertThat(stringEncoder).isNotNull();
Expand Down
Loading