Improve dashboard failure diagnostics#60
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves failure diagnostics for the pull-request dashboard refresh script. When a dashboard refresh hits PR-level failures (and refuses to publish a failed state), it now emits structured, human-readable diagnostics to stderr that identify the failed PR/thread, the classification error reason, and the preserved CLI stdout/stderr. This helps operators debug otherwise opaque workflow failures like the linked Actions run.
Changes:
- Added structured diagnostic logging helpers in
dashboard.py(log_line_value,log_multiline_value,log_failed_classification_diagnostics,log_failed_result_diagnostics) that print raw CLI output in prefixed blocks so workflow-command-looking lines stay inert. - Captured richer failure context in
classification.pyby recording anerrorreason plusresponse_text/stderrwhen a Copilot CLI classification fails, times out, or throws. - Excluded the new
stderrfield from cached classification records for consistency.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/scripts/pull-request-dashboard/dashboard.py |
Adds diagnostic helper functions and invokes them before refusing to publish a failed dashboard state. |
.github/scripts/pull-request-dashboard/classification.py |
Records error reason, response text, and stderr on classification failures/timeouts/exceptions, and excludes stderr from cached records. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mx-psi
approved these changes
Jul 9, 2026
maryliag
approved these changes
Jul 9, 2026
…iagnostics # Conflicts: # .github/scripts/pull-request-dashboard/dashboard.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can't tell why this one failed: https://github.com/open-telemetry/shared-workflows/actions/runs/28982655040
Capture Copilot classification failure details and print structured dashboard failure diagnostics before refusing to publish failed state.
The Actions log now names the failed PR/thread, includes the classification error reason, preserves failed CLI stdout/stderr, and prints raw output in prefixed blocks so workflow-command-looking lines stay inert.