Skip to content

Ignore fork PRs in check suite webhooks #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trask merged 2 commits into from
Jul 9, 2026
+37 −11
Merged

Ignore fork PRs in check suite webhooks #64

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0130f09
Ignore fork PRs in check suite webhooks
trask Jul 9, 2026
9d52bfc
update comment
trask Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 37 additions & 11 deletions .github/scripts/pull-request-dashboard/netlify/functions/github-webhook.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,9 +169,10 @@ function extractPullRequestNumber(eventName, payload) {
return payload.issue.number;
}

const checkPullRequestNumber = extractPullRequestNumberFromPullRequests([
const checkPullRequestNumber = extractPullRequestNumberFromCheckSuitePullRequests(
payload.check_suite && payload.check_suite.pull_requests,
]);
payload.repository,
);
if (checkPullRequestNumber) {
return checkPullRequestNumber;
}
Expand All @@ -187,20 +188,45 @@ function extractPullRequestNumber(eventName, payload) {
]);
}

function extractPullRequestNumberFromPullRequests(pullRequestLists) {
for (const pullRequests of pullRequestLists) {
if (!Array.isArray(pullRequests)) {
continue;
}
for (const pullRequest of pullRequests) {
if (pullRequest && Number.isInteger(pullRequest.number)) {
return pullRequest.number;
}
function extractPullRequestNumberFromCheckSuitePullRequests(pullRequests, repository) {
if (!Array.isArray(pullRequests)) {
return undefined;
}
for (const pullRequest of pullRequests) {
if (
pullRequest &&
Number.isInteger(pullRequest.number) &&
checkSuitePullRequestBelongsToRepository(pullRequest, repository)
) {
return pullRequest.number;
}
}
return undefined;
}

function checkSuitePullRequestBelongsToRepository(pullRequest, repository) {
const repositoryUrl = repository && repository.url;
if (!repositoryUrl) {
return false;
}
// check_suite.pull_requests are commit/ref associations and can point at a
// fork PR whose head is this repository. Only dispatch when the associated PR
// itself belongs to the repository that emitted this webhook event; the
// workflow dispatch passes repository + pr_number, and PR numbers are
// repository-scoped.
const pullRequestRepositoryUrl = repositoryUrlFromPullRequestApiUrl(pullRequest.url);
const baseRepositoryUrl = pullRequest.base && pullRequest.base.repo && pullRequest.base.repo.url;
return pullRequestRepositoryUrl === repositoryUrl || baseRepositoryUrl === repositoryUrl;
}

function repositoryUrlFromPullRequestApiUrl(url) {
if (typeof url !== "string") {
return "";
}
const match = url.match(/^(https:\/\/api\.github\.com\/repos\/[^/]+\/[^/]+)\/pulls\/\d+$/);
Comment thread
maryliag marked this conversation as resolved.
return match ? match[1] : "";
}

function extractPullRequestNumberFromUrls(urls) {
for (const url of urls) {
if (typeof url !== "string") {
Expand Down