bluetooth: ble: add on_advertising_terminated callback

[jialu522]

bug: v/88589

Add on_advertising_terminated callback to advertiser_callback_t, triggered by HCI LE Advertising Set Terminated event (Core Spec v6.2 Section 7.7.65.18) when Controller auto-terminates advertising.

• addr != NULL: terminated due to connection establishment
• addr == NULL: terminated due to duration/max events

Changes:

• bt_le_advertiser.h: add on_advertising_terminated_cb_t
• advertising.h/c: add LE_ADVERTISING_TERMINATED state and advertising_on_terminated() with fallback to on_advertising_stopped
• sal_le_advertise_interface.c: split ext_adv_connected/ext_adv_sent, extract peer address via bt_conn_get_dst()
• bt_message_advertiser.h: add new IPC code using BT_IPC_CODE macro
• bt_socket_advertiser.c: server sends terminated, client dispatches via BT_IPC_GET_SUBCODE with fallback to stopped
• tools/adv.c: add terminated callback with address printing

[Copilot]

Pull request overview

Adds a new BLE advertiser callback to notify clients when the controller auto-terminates an advertising set (including the peer address when termination is due to connection establishment), and propagates this event through the service layer and socket IPC.

Changes:

• Extend advertiser_callback_t with on_advertising_terminated and document the new callback semantics.
• Add advertising_on_terminated() plumbing and update Zephyr extended advertising callbacks to report termination reasons/address.
• Add a new socket IPC callback code + packet payload to deliver the terminated event to clients; update tooling to print termination details.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
tools/adv.c	Adds a terminated callback implementation that prints peer address or timeout/max-events.
service/stacks/zephyr/sal_le_advertise_interface.c	Splits ext adv callbacks and extracts peer address on connection termination.
service/src/advertising.h	Declares advertising_on_terminated() hook.
service/src/advertising.c	Stores termination metadata and dispatches to the new callback (with fallback).
service/ipc/socket/include/bt_message_advertiser.h	Introduces a new BT_IPC_CODE subcode and callback payload for termination.
service/ipc/socket/src/bt_socket_advertiser.c	Server sends terminated event; client dispatches it via subcode parsing.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

advertising_on_state_changed() allocates adv_event_t with malloc() but doesn’t initialize the newly added has_addr/addr fields. When state == LE_ADVERTISING_STOPPED, advertiser_notify_state() reads has_addr, which can be garbage and may incorrectly log a peer address and/or invoke on_advertising_terminated with uninitialized data. Initialize adv_event_t (e.g., calloc/memset or explicitly set has_addr = false).

[jialu522]

done

[Copilot]

The new on_advertising_terminated callback is only invoked when advstate->has_addr is true. This prevents delivering the “duration/max events” termination case described in the API (where addr == NULL) and instead always falls back to on_advertising_stopped. Call on_advertising_terminated whenever it is registered, passing NULL when has_addr is false; only fall back to on_advertising_stopped when the terminated callback is NULL.

Suggested change

	if (advstate->has_addr
	&& adver->callbacks.on_advertising_terminated) {
	adver->callbacks.on_advertising_terminated(
	get_adver(adver), advstate->adv_id,
	&advstate->addr);
	if (adver->callbacks.on_advertising_terminated) {
	adver->callbacks.on_advertising_terminated(
	get_adver(adver), advstate->adv_id,
	advstate->has_addr ? &advstate->addr : NULL);

[jialu522]

done

[Copilot]

advertiser_t.callbacks is populated via memcpy(&adver->callbacks, cbs, sizeof(advertiser_callback_t)) (see alloc_new_advertiser). After adding on_advertising_terminated to the struct, callers built against an older header may pass a smaller callbacks struct; this memcpy would read past the caller’s allocation and the subsequent adver->callbacks.on_advertising_terminated access can crash. Use the cbs->size field to copy only the provided bytes (bounded by sizeof(advertiser_callback_t)) and zero-initialize the remainder.

[jialu522]

done

[Copilot]

The Doxygen example block is missing leading * comment prefixes on the code lines inside @code (e.g., the void on_advertising_terminated... line). This can break generated documentation formatting. Prefix the example lines with * (or move them into a fenced Doxygen block style used elsewhere in the repo).

[gzh-terry]

Double check if we can receive the ACL connected callback before advertising is terminated.
If yes, we may use bt_conn_get_addr, which is faster, rather than bt_conn_get_dst

[jialu522]

Logs show that ext_adv_connected is received before the ACL connected callback, so bt_conn_get_dst is the safer choice here.

[gzh-terry]

Actally I would recommand to use get_le_addr_from_conn
BTW, better to check info->conn != NULL inadvance since bt_conn_get_dst is from external repository and we can not always say it's safe on null pointers.

[jialu522]

Done. Using get_le_addr_from_conn now, with info->conn != NULL guard.

[zhongzhijie1]

LGTM. advertising_on_terminated 区分 connection/timeout/max_events，ext_adv_connected 正确 NULL check bt_conn_get_dst，IPC 层 fallback 到 stopped 兼容旧客户端，cbs->size 拷贝保护向后兼容。

The merge-base changed after approval.