delete gdbus#4
Merged
Merged
Conversation
liujinye-sys
requested review from
GUIDINGLI,
huangcaihua-xm and
xiaoxiang781216
as code owners
crafcat7
pushed a commit
to crafcat7/frameworks_system_utils
that referenced
this pull request
Apr 3, 2026
When the type of basic value is double, can't using void *value as buffer to get value.
==3263760==ERROR: AddressSanitizer: stack-buffer-overflow on address 0xefe13c30 at pc 0x577c0356 bp 0xefe139b8 sp 0xefe139a8
WRITE of size 8 at 0xefe13c30 thread T0
#0 0x577c0355 in _dbus_marshal_read_basic dbus/dbus/dbus-marshal-basic.c:581
open-vela#1 0x5783bedb in _dbus_type_reader_read_basic dbus/dbus/dbus-marshal-recursive.c:879
open-vela#2 0x5776ef72 in dbus_message_iter_get_basic dbus/dbus/dbus-message.c:2376
open-vela#3 0x57e06daa in iter_append_iter gdbus/client.c:222
open-vela#4 0x57e070b1 in prop_entry_update gdbus/client.c:265
#5 0x57e07454 in prop_entry_new gdbus/client.c:286
#6 0x57e0793a in add_property gdbus/client.c:322
#7 0x57e09abd in properties_changed_non_standard gdbus/client.c:544
#8 0x57df2e00 in signal_filter gdbus/watch.c:394
#9 0x57df4d57 in message_filter gdbus/watch.c:544
#10 0x57752dc6 in dbus_connection_dispatch dbus/dbus/dbus-connection.c:4703
#11 0x57dde7d5 in message_dispatch gdbus/mainloop.c:59
#12 0x5790e3b8 in g_idle_dispatch glib/glib/gmain.c:6157
#13 0x57900a31 in g_main_dispatch glib/glib/gmain.c:3477
#14 0x579080d3 in g_main_context_dispatch glib/glib/gmain.c:4195
#15 0x57908bcc in g_main_context_iterate glib/glib/gmain.c:4271
#16 0x57909e7f in g_main_loop_run glib/glib/gmain.c:4471
#17 0x57dde5b7 in telephonytool_main /home/djz/workspace/test/sim/frameworks/telephony/telephony_tool.c:878
#18 0x56ea66b5 in nxtask_startup sched/task_startup.c:70
#19 0x56e541a8 in nxtask_start task/task_start.c:134
Signed-off-by: dongjiuzhu1 <dongjiuzhu1@xiaomi.com>
crafcat7
pushed a commit
to crafcat7/frameworks_system_utils
that referenced
this pull request
Apr 3, 2026
…r free.
when proxy is removed, proxy_free will cancel this pendcall of proxy to avoid
calling pending_reply_cb after proxy was removed, otherwise it will caused used
after free.
==174637==ERROR: AddressSanitizer: heap-use-after-free on address 0xf507c524 at pc 0x5ada152d bp 0xef013f98 sp 0xef013f88
READ of size 4 at 0xf507c524 thread T0
#0 0x5ada152c in get_properties_reply_not_standard gdbus/client.c:1271
open-vela#1 0x5ada00b3 in method_call_reply gdbus/client.c:1110
open-vela#2 0x5a527468 in _dbus_pending_call_finish_completion dbus/dbus/dbus-pending-call.c:243
open-vela#3 0x5a4e753d in complete_pending_call_and_unlock dbus/dbus/dbus-connection.c:2332
open-vela#4 0x5a4f39d4 in dbus_connection_dispatch dbus/dbus/dbus-connection.c:4663
#5 0x5a6d5451 in message_dispatch gdbus/mainloop.c:55
#6 0x5a644109 in g_idle_dispatch glib/glib/gmain.c:6157
#7 0x5a6364a3 in g_main_dispatch glib/glib/gmain.c:3477
#8 0x5a63dbdd in g_main_context_dispatch glib/glib/gmain.c:4195
#9 0x5a63e6db in g_main_context_iterate glib/glib/gmain.c:4271
#10 0x5a63f998 in g_main_loop_run glib/glib/gmain.c:4471
#11 0x5ad2ddda in telephonytool_main /home/mage1/data/specific product_sim_new/frameworks/telephony/telephony_tool.c:4465
#12 0x58f60272 in nxtask_startup sched/task_startup.c:70
#13 0x58ef82b8 in nxtask_start task/task_start.c:134
Signed-off-by: dongjiuzhu1 <dongjiuzhu1@xiaomi.com>
openvela-robot
added a commit
that referenced
this pull request
Apr 21, 2026
When the type of basic value is double, can't using void *value as buffer to get value.
==3263760==ERROR: AddressSanitizer: stack-buffer-overflow on address 0xefe13c30 at pc 0x577c0356 bp 0xefe139b8 sp 0xefe139a8
WRITE of size 8 at 0xefe13c30 thread T0
#0 0x577c0355 in _dbus_marshal_read_basic dbus/dbus/dbus-marshal-basic.c:581
#1 0x5783bedb in _dbus_type_reader_read_basic dbus/dbus/dbus-marshal-recursive.c:879
#2 0x5776ef72 in dbus_message_iter_get_basic dbus/dbus/dbus-message.c:2376
#3 0x57e06daa in iter_append_iter gdbus/client.c:222
#4 0x57e070b1 in prop_entry_update gdbus/client.c:265
#5 0x57e07454 in prop_entry_new gdbus/client.c:286
#6 0x57e0793a in add_property gdbus/client.c:322
#7 0x57e09abd in properties_changed_non_standard gdbus/client.c:544
#8 0x57df2e00 in signal_filter gdbus/watch.c:394
#9 0x57df4d57 in message_filter gdbus/watch.c:544
#10 0x57752dc6 in dbus_connection_dispatch dbus/dbus/dbus-connection.c:4703
#11 0x57dde7d5 in message_dispatch gdbus/mainloop.c:59
#12 0x5790e3b8 in g_idle_dispatch glib/glib/gmain.c:6157
#13 0x57900a31 in g_main_dispatch glib/glib/gmain.c:3477
#14 0x579080d3 in g_main_context_dispatch glib/glib/gmain.c:4195
#15 0x57908bcc in g_main_context_iterate glib/glib/gmain.c:4271
#16 0x57909e7f in g_main_loop_run glib/glib/gmain.c:4471
#17 0x57dde5b7 in telephonytool_main /home/djz/workspace/test/sim/frameworks/telephony/telephony_tool.c:878
#18 0x56ea66b5 in nxtask_startup sched/task_startup.c:70
#19 0x56e541a8 in nxtask_start task/task_start.c:134
Signed-off-by: dongjiuzhu1 <dongjiuzhu1@xiaomi.com>
openvela-robot
pushed a commit
that referenced
this pull request
Apr 21, 2026
…r free.
when proxy is removed, proxy_free will cancel this pendcall of proxy to avoid
calling pending_reply_cb after proxy was removed, otherwise it will caused used
after free.
==174637==ERROR: AddressSanitizer: heap-use-after-free on address 0xf507c524 at pc 0x5ada152d bp 0xef013f98 sp 0xef013f88
READ of size 4 at 0xf507c524 thread T0
#0 0x5ada152c in get_properties_reply_not_standard gdbus/client.c:1271
#1 0x5ada00b3 in method_call_reply gdbus/client.c:1110
#2 0x5a527468 in _dbus_pending_call_finish_completion dbus/dbus/dbus-pending-call.c:243
#3 0x5a4e753d in complete_pending_call_and_unlock dbus/dbus/dbus-connection.c:2332
#4 0x5a4f39d4 in dbus_connection_dispatch dbus/dbus/dbus-connection.c:4663
#5 0x5a6d5451 in message_dispatch gdbus/mainloop.c:55
#6 0x5a644109 in g_idle_dispatch glib/glib/gmain.c:6157
#7 0x5a6364a3 in g_main_dispatch glib/glib/gmain.c:3477
#8 0x5a63dbdd in g_main_context_dispatch glib/glib/gmain.c:4195
#9 0x5a63e6db in g_main_context_iterate glib/glib/gmain.c:4271
#10 0x5a63f998 in g_main_loop_run glib/glib/gmain.c:4471
#11 0x5ad2ddda in telephonytool_main /home/mage1/data/n62_sim_new/frameworks/telephony/telephony_tool.c:4465
#12 0x58f60272 in nxtask_startup sched/task_startup.c:70
#13 0x58ef82b8 in nxtask_start task/task_start.c:134
Signed-off-by: dongjiuzhu1 <dongjiuzhu1@xiaomi.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Please adhere to Contributing Guidelines.
Summary
delete gdbus