feat: Review and increase E2E test coverage#247
Open
kumaradityaraj wants to merge 5 commits into
Open
Conversation
Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Expands Playwright E2E coverage for the Serverless Workflow diagram editor by adding new Storybook-driven scenarios around node rendering and validation error presentation.
Changes:
- Added new E2E specs for conditional task, for-loop container rendering, and listen/foreach variants.
- Added an E2E spec asserting document-level validation errors are shown in the sidebar.
- Added a Changesets entry for
@serverlessworkflow/diagram-editor.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/serverless-workflow-diagram-editor/tests-e2e/validation-error.spec.ts | New E2E test for document-level validation errors in the sidebar. |
| packages/serverless-workflow-diagram-editor/tests-e2e/forever-foreach.spec.ts | New E2E test for listen node rendering with validation error indicator/badge. |
| packages/serverless-workflow-diagram-editor/tests-e2e/for-loop.spec.ts | New E2E test for for container rendering and nested listen node/badge. |
| packages/serverless-workflow-diagram-editor/tests-e2e/conditional-task.spec.ts | New E2E test for conditional workflow rendering, start/end nodes, and edge label. |
| .changeset/e2e-tests.md | Versioning/release-note entry for the diagram-editor package. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
fantonangeli
suggested changes
Jul 13, 2026
fantonangeli
left a comment
fantonangeli
left a comment
Member
There was a problem hiding this comment.
The PR description should start with:
Closes https://github.com/open-workflow-specification/editor/issues/98
so GH will automatically connect the PR to the issue
Member
There was a problem hiding this comment.
This PR introduces tests but has no changes for the user, so I don't think we should add this changeset.
Wdyt?
Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
✅ Deploy Preview for swf-editor ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
fantonangeli
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #98
Description
Expanded the Playwright end-to-end test coverage for workflow diagram rendering and validation scenarios.
Added diagram rendering tests
Added validation tests
To test it
run pnpm test-e2e