fix: accept dsl versions with pre-release tags for minimum in range - #292
Merged
JBBianchi merged 2 commits intoJul 27, 2026
Merged
Conversation
Signed-off-by: Lorna Kelly <lornakelly88@gmail.com>
Signed-off-by: Lorna Kelly <lornakelly88@gmail.com>
lornakelly
force-pushed
the
291/dsl-validation-fix
branch
from
July 24, 2026 10:10
5c84290 to
0424271
Compare
Contributor
Author
|
@JBBianchi @ricardozanini Want to confirm that the correct logic is we accept versions that have identifiers for both the minimum and maximum range (1.0.0, 1.0.3), please correct if any of the below is NOT what we want:
|
lornakelly
marked this pull request as ready for review
July 24, 2026 13:05
ricardozanini
approved these changes
Jul 24, 2026
ricardozanini
left a comment
ricardozanini
left a comment
Collaborator
There was a problem hiding this comment.
LGTM!
Yes, that's what we are expecting. Many thanks, @lornakelly
JBBianchi
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
Fixes #291
What this PR does / why we need it:
Fixes DSL version validation rejecting valid dsl versions. The valid range was 1.0.0 >=1.0.3 which meant valid versions like
1.0.0-alphawere incorrectly rejected. The previous PR #267 purposely rejected these but the rejection logic was incorrect as they should be considered validUpdated supported range to
1.0.0-0 >=1.0.3so those values are now acceptedSpecial notes for reviewers:
Additional information (if needed):