[CI / BUGFIX] Fixed disagreeing uv versions across project#958
Open
calumbell wants to merge 4 commits into
Open
[CI / BUGFIX] Fixed disagreeing uv versions across project#958calumbell wants to merge 4 commits into
uv versions across project#958calumbell wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug I encountered with our CI pipeline while authoring #956. To quote from issue #957, here is the error message thrown by the Github Actions CI pipeline:
So we had an issue here where our Dockerfile was running a different
uvversion (0.9.30) to the rest of the project (>=0.10), and this was causing the Docker build process to fail.I had a dig around, and found that these issues are fairly well documented here: https://docs.astral.sh/uv/guides/integration/docker
This issue was with this specific line:
Combined uv/python build images were discontinued after uv version 0.9, which is why this line is setting the
uvversion to 0.9.30, out of step with the rest of the project.The documents suggest the following as a solution:
Which pulls the
uvbinaries into the Docker build stage, which replicates how the deprecated bookworm combined images used to work.Related Issue
Closes #957
How was this tested?