-
Notifications
You must be signed in to change notification settings - Fork 3
Replace error with warning for unmapped instance folders #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
0d4dbe7
Update getSchemaName.m
ehennestad dc56c7c
Warn once for unmapped instance folders
ehennestad 86ced8e
Update getModelVersion.m
ehennestad 727ee9c
Merge branch 'fix-get-schema-name' into hotfix-instance-library-breaks
ehennestad bfd797f
Temporarily skip latest model version assertion in MetaTypeTest
ehennestad 609019c
debug uriJoin
ehennestad 05b6011
debug urijoin
ehennestad 819298b
debug
ehennestad 51f2de5
Remove debug code, more targeted version pin in getControlledInstances
ehennestad 4a8f103
Update getControlledInstance.m
ehennestad 62b5c51
Update testReadTheDocLinks.m
ehennestad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
4 changes: 4 additions & 0 deletions
4
code/internal/+openminds/+internal/+utility/+string/uriJoin.m
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,14 @@ | ||
| function strURI = uriJoin(varargin) | ||
| %uriJoin Join segments of a URI using the forward slash (/) | ||
| try | ||
| if isa(varargin{1}, 'string') | ||
| listOfStrings = [varargin{:}]; | ||
| strURI = join(listOfStrings, "/"); | ||
| elseif isa(varargin{1}, 'char') | ||
| listOfStrings = varargin; | ||
| strURI = strjoin(listOfStrings, '/'); | ||
| end | ||
| catch | ||
| varargin{:} | ||
|
|
||
| end | ||
| end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.