Skip to content

Update tests to latest/v5 #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
apdavison merged 6 commits into from
Mar 18, 2026
Merged

Update tests to latest/v5 #89

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
56012bb
Update test_collections.py to latest/v5
Raphael-Gazzotti Mar 11, 2026
fbc720a
* Update DEFAULT_VERSION global variable
Raphael-Gazzotti Mar 13, 2026
958b137
* Add regression test test_issue0005b
Raphael-Gazzotti Mar 13, 2026
3f65ff5
* Add regression test test_issue0007b
Raphael-Gazzotti Mar 13, 2026
fd196aa
Add updated tests to test_regressions.py
Raphael-Gazzotti Mar 13, 2026
060fab2
Cleanup of unused code
Raphael-Gazzotti Mar 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
81 changes: 48 additions & 33 deletions pipeline/tests/test_collections.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,7 @@ def test_round_trip_single_file():
collection.save(test_file_path, individual_files=False, include_empty_properties=False)

new_collection = Collection()
new_collection.load(test_file_path)

new_collection.load(test_file_path, version='latest')
assert len(collection) == len(new_collection)

for node in new_collection:
Expand All @@ -63,7 +62,7 @@ def test_round_trip_multi_file():
collection = Collection(person)
collection.save(test_output_dir, individual_files=True, include_empty_properties=False)
new_collection = Collection()
new_collection.load(test_output_dir)
new_collection.load(test_output_dir, version='latest')

assert len(collection) == len(new_collection)

Expand All @@ -83,7 +82,7 @@ def test_round_trip_multi_file_group_by_schema():
collection = Collection(person)
collection.save(test_output_dir, individual_files=True, include_empty_properties=False, group_by_schema=True)
new_collection = Collection()
new_collection.load(test_output_dir)
new_collection.load(test_output_dir, version='latest')

assert len(collection) == len(new_collection)

Expand All @@ -98,12 +97,14 @@ def test_round_trip_multi_file_group_by_schema():


def test_collection_sort_by_id():
person = omcore.Person(given_name="A", family_name="Professor", id="_:004")
uni1 = omcore.Organization(full_name="University of This Place", id="_:002")
uni2 = omcore.Organization(full_name="University of That Place", id="_:001")
person.affiliations = [
omcore.Affiliation(member_of=uni1),
omcore.Affiliation(member_of=uni2),
person = omcore.Person(preferred_name="A", family_name="Professor", id="_:004")
uni1 = omcore.Organization(name="University of This Place", id="_:002")
uni2 = omcore.Organization(name="University of That Place", id="_:001")
uni1.membershipss = [
omcore.Membership(member=person),
]
uni2.membershipss = [
omcore.Membership(member=person),
]

c = Collection(person, uni1, uni2)
Expand All @@ -116,29 +117,43 @@ def test_collection_sort_by_id():
os.remove("test_collection_sort_by_id.jsonld")

expected_saved_data = {
"@context": {"@vocab": "https://openminds.om-i.org/props/"},
"@graph": [
{
"@id": "_:001",
"@type": "https://openminds.om-i.org/types/Organization",
"fullName": "University of That Place",
},
{
"@id": "_:002",
"@type": "https://openminds.om-i.org/types/Organization",
"fullName": "University of This Place",
},
{
"@id": "_:004",
"@type": "https://openminds.om-i.org/types/Person",
"affiliation": [
{"@type": "https://openminds.om-i.org/types/Affiliation", "memberOf": {"@id": "_:002"}},
{"@type": "https://openminds.om-i.org/types/Affiliation", "memberOf": {"@id": "_:001"}},
],
"familyName": "Professor",
"givenName": "A",
},
],
"@context":{
"@vocab":"https://openminds.om-i.org/props/"
},
"@graph":[
{
"@id":"_:001",
"@type":"https://openminds.om-i.org/types/Organization",
"memberships":[
{
"@type":"https://openminds.om-i.org/types/Membership",
"member":{
"@id":"_:004"
}
}
],
"name":"University of That Place"
},
{
"@id":"_:002",
"@type":"https://openminds.om-i.org/types/Organization",
"memberships":[
{
"@type":"https://openminds.om-i.org/types/Membership",
"member":{
"@id":"_:004"
}
}
],
"name":"University of This Place"
},
{
"@id":"_:004",
"@type":"https://openminds.om-i.org/types/Person",
"familyName":"Professor",
"preferredName":"A"
}
]
}

assert saved_data == expected_saved_data
Loading