Skip to content

fix: prefer exact PATH during trusted executable resolution #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GautamSharma99 wants to merge 1 commit into
base: main
Choose a base branch
from
+42 −3
Open

fix: prefer exact PATH during trusted executable resolution #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions sdk/typescript/src/trusted-executable.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,11 @@ export async function resolveTrustedExecutable(
const root = await realpath(protectedRoot).catch(() =>
resolve(protectedRoot),
);
const path = Object.entries(environment).find(
([name]) => name.toUpperCase() === "PATH",
)?.[1];
const path =
environment["PATH"] ??
Object.entries(environment).find(
([name]) => name.toUpperCase() === "PATH",
)?.[1];
const entries: string[] = [];
for (const entry of path?.split(delimiter) ?? []) {
if (entry.length === 0 || !isAbsolute(entry)) continue;
Expand Down
37 changes: 37 additions & 0 deletions sdk/typescript/tests-ts/trusted-executable.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,43 @@ async function resolveWindowsExecutable(
}

describe("trusted executable resolution", () => {
test.skipIf(process.platform === "win32")(
"prefers the exact POSIX PATH over an earlier lowercase path variable",
async () => {
const root = await temporaryDirectory();
const repository = join(root, "repository");
const decoy = join(root, "decoy");
const trusted = join(root, "trusted");
await Promise.all([mkdir(repository), mkdir(decoy), mkdir(trusted)]);
await Promise.all([
writeFile(join(decoy, "git"), "#!/bin/sh\nexit 1\n"),
writeFile(join(trusted, "git"), "#!/bin/sh\nexit 0\n"),
]);
await Promise.all([
chmod(join(decoy, "git"), 0o700),
chmod(join(trusted, "git"), 0o700),
]);

await expect(
resolveTrustedExecutable(
"git",
{
path: decoy,
PATH: trusted,
KEEP: "ok",
},
repository,
),
).resolves.toEqual({
executable: join(trusted, "git"),
environment: {
KEEP: "ok",
PATH: trusted,
},
});
},
);

test.skipIf(process.platform === "win32")(
"preserves the invocation name of a trusted symlinked executable",
async () => {
Expand Down