fix: expand ~ in CLI and bulk-scan wizard path arguments - #143
Open
mangeshraut712 wants to merge 1 commit into
Open
fix: expand ~ in CLI and bulk-scan wizard path arguments#143mangeshraut712 wants to merge 1 commit into
mangeshraut712 wants to merge 1 commit into
Conversation
|
Note You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
mangeshraut712
force-pushed
the
fix/cli-tilde-path-expansion
branch
from
July 30, 2026 17:21
9de7b67 to
8f5d899
Compare
scan already expanded home-relative paths, but bulk-scan, export, scans list, install-hook, and the interactive wizard resolved paths with bare resolve(), so ~/... became a literal directory named ~. Share expandHome via resolveCliPath across those entry points. Prefer HOME/USERPROFILE with bracket access for TypeScript index-signature compliance. Fixes openai#57
mangeshraut712
force-pushed
the
fix/cli-tilde-path-expansion
branch
from
July 30, 2026 17:28
8f5d899 to
6811302
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
~,~/..., and~\...for path-typed CLI inputs outsidescan(bulk-scan CSV/--output-dir, export scan/output/source-root, scans list repository/--scan-root, install-hook repository, and the bulk-scan wizard output prompt).expandHomevia a sharedresolveCliPathhelper; leaves non-path validate inputs andexport --output -unchanged.HOME/USERPROFILEwhen expanding so Windows and isolated tests behave consistently.Test plan
~/custom-results→ home-relative output, no<cwd>/~bulk-scan ~/repositories.csv --output-dir ~/security-scansfrom another cwd