Refresh callable Azure API keys before requests#2992
Refresh callable Azure API keys before requests#2992LittleChenLiya wants to merge 4 commits intoopenai:mainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1a67dbb199
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
1 participant
Summary
Fix Azure clients so callable
api_keyproviders are refreshed before each request.AzureOpenAIandAsyncAzureOpenAIoverride_prepare_options()to add Azure-specific auth headers, but they were not refreshing callable API keys before setting theapi-keyheader. As a result, dynamic API key providers were not applied to requests or retries.Changes
AzureOpenAI._prepare_options()AsyncAzureOpenAI._prepare_options()api_keyproviders across retriesTesting
python -m pytest tests/lib/test_azure.py -n 0python -m pytest tests/test_client.py -k "api_key_before_after_refresh or api_key_refresh_on_retry or bearer_token_refresh_async" -n 0Closes #2626