fix: add missing f-string prefix in async_to_httpx_files error message#3039
Open
Quratulain-bilal wants to merge 1 commit intoopenai:mainfrom
Open
fix: add missing f-string prefix in async_to_httpx_files error message#3039Quratulain-bilal wants to merge 1 commit intoopenai:mainfrom
Quratulain-bilal wants to merge 1 commit intoopenai:mainfrom
Conversation
The TypeError in `async_to_httpx_files` was missing the `f` prefix,
causing the error message to display the literal string
`{type(files)}` instead of the actual type. The sync version
`to_httpx_files` (line 58) correctly uses an f-string.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fprefix on the f-string inasync_to_httpx_files()(src/openai/_files.py,line 100)
to_httpx_files()(line 58) correctly usesf"Unexpected file type input {type(files)}...", but the async counterpart was missing thefprefix{type(files)}instead of the actualtype
Bug Details
Before (broken):