Fix: None case handling in response.output parsing#3320
Closed
JenuelDev wants to merge 1 commit into
Closed
Conversation
It seems that sometimes the response.output returns null and it throws an error.
|
Thanks for the quick fix. This is a duplicate of the earlier PR: This PR applies the same
I compared the diff and did not find extra behavior here that needs to be pulled into #3315. |
Author
|
Going to close this PR then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a small but important change to the response parsing logic to improve robustness when handling API responses.
parse_responsewithinsrc/openai/lib/_parsing/_responses.pyby ensuring the code safely iterates overresponse.outputeven if it isNone, preventing possible runtime errors.