Skip to content

Reduce install size: make ipyparallel/matplotlib optional - #13

Open
danifr wants to merge 6 commits into
masterfrom
reduce-install-size
Open

danifr wants to merge 6 commits into
masterfrom
reduce-install-size

Conversation

@danifr

@danifr danifr commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

for #6

I asked an LLM to make the changes based on @eleftherioszisis original description. I think the changes make sense, in any case please double check carefully @darshanmandge

Related to https://github.com/openbraininstitute/INFRA/issues/283

@danifr
danifr requested a review from darshanmandge October 26, 2026 11:17
@codecov

codecov Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
bluepyopt/ipyp/bpopt_tasksdb.py 0.00% 9 Missing ⚠️
Files with missing lines Coverage Δ
bluepyopt/ipyp/bpopt_tasksdb.py 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@danifr

danifr commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor Author

Results — install size, old vs new (default pip install bluepyopt)

┌────────────────────┬───────────────────────┬───────────────────────┐
│                    │ OLD (861b64c, pre-PR) │ NEW (44fcee4, PR #13) │
├────────────────────┼───────────────────────┼───────────────────────┤
│ site-packages size │ 527.7 MiB             │ 410.9 MiB             │
├────────────────────┼───────────────────────┼───────────────────────┤
│ installed packages │ 55                    │ 26                    │
└────────────────────┴───────────────────────┴───────────────────────┘

Reduction: 116.8 MiB smaller (−22.1%), 29 fewer packages.

@danifr danifr closed this Oct 26, 2026
@danifr danifr reopened this Oct 26, 2026

@darshanmandge darshanmandge left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @danifr. I left a comment. I will have to test the examples and tests again once the changes are done.

Comment thread pyproject.toml
"deap>=1.3.3",
"efel>=2.13",
"ipyparallel",
"pickleshare>=0.7.3",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be a breaking change for packages that rely on ipyparallel being available indirectly through bluepyopt. The main l5PC example of bluepyopt also uses it. Maybe you can add a line to the example README or add the ipyparallel installation in the notebook or before launching the script.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, I will add a new commit documenting the pip install bluepyopt[ipyp] requirement

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants