Repository navigation
Conversation
…) and drop tests from wheel (#6)
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
|
Results — install size, old vs new (default pip install bluepyopt) Reduction: 116.8 MiB smaller (−22.1%), 29 fewer packages. |
darshanmandge
left a comment
There was a problem hiding this comment.
Thanks, @danifr. I left a comment. I will have to test the examples and tests again once the changes are done.
| "deap>=1.3.3", | ||
| "efel>=2.13", | ||
| "ipyparallel", | ||
| "pickleshare>=0.7.3", |
There was a problem hiding this comment.
This could be a breaking change for packages that rely on ipyparallel being available indirectly through bluepyopt. The main l5PC example of bluepyopt also uses it. Maybe you can add a line to the example README or add the ipyparallel installation in the notebook or before launching the script.
There was a problem hiding this comment.
yep, I will add a new commit documenting the pip install bluepyopt[ipyp] requirement
for #6
I asked an LLM to make the changes based on @eleftherioszisis original description. I think the changes make sense, in any case please double check carefully @darshanmandge
Related to https://github.com/openbraininstitute/INFRA/issues/283