fix(docs-site): language menu collapsed to one row after redesign#90
Merged
Conversation
The redesign moved the language picker inside .header-links, so the
generic .header-links a{display:inline-flex} rule out-specified
.language-option{display:grid} and the menu rendered as a one-row
horizontal strip — only the active language was visible. Scope the
header link rules to direct children (.header-links>a) and add smoke
contracts: no descendant anchor rules under .header-links, and menu
options must stack as grid rows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The redesign (#89) moved the language picker into
.header-links, where the generic.header-links a{display:inline-flex}rule out-specifies.language-option{display:grid}— the dropdown rendered as a single horizontal row clipping all but the active language.Scope the header anchor rules to direct children (
.header-links>a) so menu options stack again, and add smoke contracts (no descendant anchor rules under.header-links; options must be grid rows).Verified with Playwright against the built shell: 21 options stacked in a 430px scrollable menu, header icon links unaffected.