Skip to content

feat(config): add embedding endpoint override#117

Merged
steipete merged 1 commit into
mainfrom
feat/embed-base-url
Jul 17, 2026
Merged

feat(config): add embedding endpoint override#117
steipete merged 1 commit into
mainfrom
feat/embed-base-url

Conversation

@steipete

Copy link
Copy Markdown
Contributor

Supersedes #99 with the maintainer-approved narrow configuration surface.

What changed

  • add one persisted openai.embed_base_url setting, --embed-base-url, and GITCRAWL_EMBED_BASE_URL
  • retain the shared GITCRAWL_OPENAI_BASE_URL / OPENAI_BASE_URL fallback
  • route both stored-thread and semantic-query embedding requests through the embedding-specific resolver
  • expose the active endpoint in configure and doctor output
  • document configuration, precedence, and clearing behavior

The unused summary-specific endpoint from #99 is intentionally omitted. Thanks @larroy for the original implementation and direction.

Proof

  • full Go gate, vulnerability scan, deadcode scan, 85.1% coverage, build smokes, release-script tests, and GoReleaser snapshot passed
  • AutoReview clean with no accepted/actionable findings
  • real 0.8.1-pr99 binary synced pull request 99, selected one embedding record, and completed one request against a loopback OpenAI-compatible endpoint
  • loopback server observed one authenticated /v1/embeddings request with one input, model text-embedding-3-small, and 1024 requested dimensions
  • shared endpoint pointed at an unreachable loopback port during the successful run; clearing embed_base_url then failed through that shared endpoint without another stub request

Co-authored-by: Pedro Larroy <pedro.larroy.lists@gmail.com>
@steipete
steipete merged commit 2c26a60 into main Jul 17, 2026
10 checks passed
@steipete
steipete deleted the feat/embed-base-url branch July 17, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant