[stable-7.2] chore: bump reva to 2.46.4#2967
Conversation
rhafer
changed the title
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
🟢 Coverage 0.00% diff coverage · +0.00% coverage variation
Metric Results Coverage variation ✅ +0.00% coverage variation (-1.00%) Diff coverage ✅ 0.00% diff coverage Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (4d82968) 81377 18676 22.95% Head commit (4422bf4) 81377 (+0) 18678 (+2) 22.95% (+0.00%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#2967) 1 0 0.00% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
rhafer
force-pushed
the
stable/7.2/reva-2.46.4
branch
from
bb6b89b to
c60b788
Compare
|
The tests are failing because the server is returning a different error than expected when a user with the Currently the implementation returns a IMO neither 404 nor 400 are really correct here. I'd think the server should return a 403 as the user does have access to the space (i.e. can re-enable it) but is just not allowed to purge it. I'm working on a fix. (Likely requires yet another reva bump). |
Allow a "permission denied error" from reva to bubble up to the client. Reva was fixed to return "permission denied" only when the space to be delete can actually be listed by the user. Other wise it will return "not found". See reva commit 1bf72cb76394671f373e87f15f23f978cf41ab08. So when a user with the 'can manage' role tries to purge an already disabled space it will now get "Forbidden" status instead of a "Not found". Also fixes the expected status codes in the tests. (cherry picked from commit e86381d)
rhafer
force-pushed
the
stable/7.2/reva-2.46.4
branch
from
c60b788 to
4422bf4
Compare
2 participants
Changes
2.46.4 - 2026-06-17
🐛 Bug Fixes