Skip to content

DHCP-less/inband Bootz spec changes#316

Open
gmacf wants to merge 7 commits into
openconfig:mainfrom
gmacf:inband
Open

DHCP-less/inband Bootz spec changes#316
gmacf wants to merge 7 commits into
openconfig:mainfrom
gmacf:inband

Conversation

@gmacf
Copy link
Copy Markdown
Contributor

@gmacf gmacf commented May 12, 2026

No description provided.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a DHCP-less (inband) operating mode for Bootz, updating the documentation to include new entry points, cleanup procedures, and a standardized CLI specification across Unary Bootz and BootstrapStream (v0.6 and v1.0) protocols. Review feedback highlights a numbering error in the Unary Bootz section and suggests consistent formatting for the cleanup steps across all protocol versions.

Comment thread README.md
Comment thread README.md Outdated
gmacf and others added 3 commits May 12, 2026 15:57
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@gmacf gmacf changed the title [DRAFT] DHCP-less/inband Bootz spec changes DHCP-less/inband Bootz spec changes May 15, 2026
@gmacf gmacf requested review from Chounoki, marcushines and xw-g May 15, 2026 05:21
@gmacf gmacf marked this pull request as ready for review May 15, 2026 05:21
Comment thread README.md
Comment thread README.md
Comment thread README.md
Comment thread README.md
Comment thread README.md Outdated
Comment thread README.md Outdated
@gmacf
Copy link
Copy Markdown
Contributor Author

gmacf commented May 26, 2026

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation in README.md to introduce and specify the DHCP-less (inband) operating mode for Bootz. It details the entry points, recovery loops, cleanup procedures, standardized CLI commands (initiate, reset, terminate), and includes Mermaid sequence diagrams for various failure and termination scenarios. The review feedback focuses on correcting Markdown indentation for nested lists under the DHCP-less options, standardizing the 'Cleanup' section headers across BootstrapStream versions for consistency, and aligning the logging terminology with the actual CLI command names.

Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md
Comment thread README.md
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md
Comment thread README.md
* Drop the commit interception feature
* Remove references in 'inband'
* Clarify the scope of the reset command
* Clarify the cleanup step
@gmacf gmacf requested review from LimeHat, NishadCM and cpeng90 June 5, 2026 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants