Adding 800G Speed support for portSpeed

[ameya-kadam]

Adding 800G Speed definition for portSpeed

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the telemetry port speed test suite to include support for 800G interface speeds. By extending the existing speed mapping configuration, the test framework is now capable of correctly identifying and validating 800G port configurations.

Highlights

• 800G Speed Support: Added the 800G speed mapping to the port speed configuration map to support higher bandwidth testing.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #5480 / 303da34

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		gNMI-1.5: Telemetry: Port Speed Test
Cisco 8000E		gNMI-1.5: Telemetry: Port Speed Test
Cisco XRd		gNMI-1.5: Telemetry: Port Speed Test
Juniper ncPTX		gNMI-1.5: Telemetry: Port Speed Test
Nokia SR Linux		gNMI-1.5: Telemetry: Port Speed Test
Openconfig Lemming		gNMI-1.5: Telemetry: Port Speed Test

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		gNMI-1.5: Telemetry: Port Speed Test
Cisco 8808		gNMI-1.5: Telemetry: Port Speed Test
Juniper PTX10008		gNMI-1.5: Telemetry: Port Speed Test
Nokia 7250 IXR-10e		gNMI-1.5: Telemetry: Port Speed Test

Help

[gemini-code-assist]

Code Review

This pull request adds 800Gb speed support to the local portSpeed map in the telemetry port speed test. While this enables telemetry validation for that speed, feedback indicates that the implementation is incomplete. The test's configuration phase relies on a shared library in internal/fptest/portspeed.go which still lacks this mapping, leading to potential failures when the ExplicitPortSpeed deviation is enabled. It is recommended to move the 800Gb entry to the shared library to ensure full support and promote reusability across tests.

[gemini-code-assist]

The addition of 800G support to the local portSpeed map enables telemetry validation for this speed. However, the test's configuration phase (via fptest.SetPortSpeed at line 221) will still fail to configure 800G when the ExplicitPortSpeed deviation is enabled. This is because fptest.SetPortSpeed depends on the portSpeed map in internal/fptest/portspeed.go, which lacks this mapping. The 800G entry should be added to the shared library to provide complete support and promote reusability across tests.

References

1. Constants that may be applicable to multiple vendors in the future should be kept general, even if they are currently used in a vendor-specific context, to promote reusability.