Skip to content

Updating supervisor switchover test as per readme modifications#5488

Open
rohit-rp wants to merge 2 commits into
openconfig:mainfrom
rohit-rp:sup_failover
Open

Updating supervisor switchover test as per readme modifications#5488
rohit-rp wants to merge 2 commits into
openconfig:mainfrom
rohit-rp:sup_failover

Conversation

@rohit-rp
Copy link
Copy Markdown
Contributor

@rohit-rp rohit-rp commented May 19, 2026

  • Modified the readme to reduce number of progr ammed prefixes from 50 to 25
    • Originally only 1 prefix was being programmed
    • I had updated the readme to include 50 prefixes in this PR but 25 seems to work efficiently
  • Updated the test as per the README changes
  • b/514766988 has the pass logs on MFF hardware for all vendors

@rohit-rp rohit-rp requested a review from a team as a code owner May 19, 2026 18:09
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the supervisor failure test suite to better align with the specified test documentation. It modifies the scale of the test by reducing the number of prefixes used and expands the test coverage to include IPv6 validation. Additionally, the test structure has been refactored to support a multi-phase validation approach, ensuring that FIB entries persist correctly across supervisor switchovers and that post-switchover programming functions as expected.

Highlights

  • Test Logic Update: Updated the supervisor switchover test to align with README requirements, reducing the number of IPv4 and IPv6 entries from 50 to 25 each.
  • Test Coverage Expansion: Added support for IPv6 traffic flows and implemented a two-phase validation process covering both pre- and post-switchover FIB programming.
  • Code Refactoring: Introduced helper functions for route programming (programRoutes) and AFT telemetry verification (verifyAftTelemetry) to improve test readability and maintainability.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@OpenConfigBot
Copy link
Copy Markdown

Pull Request Functional Test Report for #5488 / daa02ce

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
TE-8.2: Supervisor Failure
2cf71528 Log
Cisco 8000E status
TE-8.2: Supervisor Failure
bb5563eb Log
Cisco XRd status
TE-8.2: Supervisor Failure
6839b969 Log
Juniper ncPTX status
TE-8.2: Supervisor Failure
863e6cbb Log
Nokia SR Linux status
TE-8.2: Supervisor Failure
0813d364 Log
Openconfig Lemming status
TE-8.2: Supervisor Failure
82146afe Log

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
TE-8.2: Supervisor Failure
Cisco 8808 status
TE-8.2: Supervisor Failure
Juniper PTX10008 status
TE-8.2: Supervisor Failure
Nokia 7250 IXR-10e status
TE-8.2: Supervisor Failure

Help

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances the supervisor failure test by adding IPv6 support and refactoring the route programming and traffic verification logic. Key changes include updating the test documentation, introducing specific traffic flows for IPv4 and IPv6 across initial and post-switchover phases, and utilizing helper functions for AFT telemetry validation. The number of prefixes programmed in each phase has been adjusted to 25 for each IP version. I have no feedback to provide.

@gggsmith gggsmith assigned miled25 and unassigned gggsmith May 21, 2026
@gggsmith gggsmith self-requested a review May 21, 2026 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants