Otg gnpsi-1 update for Cisco run

[ijernoiu]

No description provided.

[OpenConfigBot]

Pull Request Functional Test Report for #5525 / 72c0bcb

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		gNPSI-1: Sampling and Subscription Check
Cisco 8000E		gNPSI-1: Sampling and Subscription Check
Cisco XRd		gNPSI-1: Sampling and Subscription Check
Juniper ncPTX		gNPSI-1: Sampling and Subscription Check
Nokia SR Linux		gNPSI-1: Sampling and Subscription Check
Openconfig Lemming		gNPSI-1: Sampling and Subscription Check

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		gNPSI-1: Sampling and Subscription Check
Cisco 8808		gNPSI-1: Sampling and Subscription Check
Juniper PTX10008		gNPSI-1: Sampling and Subscription Check
Nokia 7250 IXR-10e		gNPSI-1: Sampling and Subscription Check

Help

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces necessary updates to the gNPSI and sFlow testing infrastructure to improve compatibility with Cisco platforms. It includes adjustments to test configuration parameters, dynamic handling of sampling rates, and the addition of platform-specific deviation flags to ensure tests run correctly across different vendor implementations.

Highlights

• Cisco Platform Support: Added platform-specific deviations for Cisco devices to handle sFlow sampling rates and gNPSI export requirements.
• gNPSI Configuration: Updated the gNPSI configuration plugin to support OpenConfig-based configuration and added necessary parameters like ServerName and NetworkInstance.
• sFlow Test Improvements: Refined sFlow sampling tests to use dynamic channel capacities based on device-specific sampling rates and improved validation logic.
• Infrastructure Updates: Added a new deviation flag 'missing_sflow_gnpsi_export' and updated internal configuration helpers to support CLI-based gNPSI export for specific vendors.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces support for gNPSI configuration and sFlow gNPSI export, particularly addressing Cisco-specific deviations. It implements gNPSI configuration from OpenConfig (OC) using gNMI, adds a new deviation missing_sflow_gnpsi_export to handle sFlow export configuration via CLI on Cisco devices, and updates the sampling test to dynamically adjust expected sampling rates and channel capacities based on the sflow_ingress_min_sampling_rate deviation. Additionally, a typo was fixed in the topology binding options. The reviewer recommended refactoring duplicated logic for determining the effective sampling rate into a single helper function to improve maintainability.

[ijernoiu]

Updated the deviation details