fix: Upgrade EC2 runners to 2.6.1 to support Node.js 24#126
Conversation
📝 WalkthroughWalkthroughTwo GitHub Actions workflow files — Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Supply chain surface (CWE-1357 / CWE-693): This is a mutable tag pin, not a SHA pin. 🚥 Pre-merge checks | ✅ 10✅ Passed checks (10 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/execute-all-notebooks.yml:
- Around line 49-51: The EC2 GitHub runner actions have a version mismatch
between start and stop operations. In the file execute-all-notebooks.yml, the
start action machulav/ec2-github-runner at line 49-51 uses version v2.6.1, but
the corresponding stop action at line 164 uses the older v2.4.3. Similarly, in
execute-kfp-localrunners.yml, the stop action at line 186 also uses v2.4.3.
Update both stop actions to reference version v2.6.1 instead of v2.4.3 by
changing the hash reference for the machulav/ec2-github-runner stop action to
match the version used in the start action.
In @.github/workflows/execute-kfp-localrunners.yml:
- Around line 71-73: The "Stop EC2 runner" action at line 186 is using version
v2.4.3 (Node 20) which is incompatible with GitHub's enforced Node 24 runtime,
while the "Start Data Processing EC2 runner" action uses the compatible v2.6.1.
Update the Stop EC2 runner action to use the same version v2.6.1 with commit
hash 343a1b2ae682e681c3cec9a235d882da17ff04ef to ensure consistency and prevent
potential failures when terminating EC2 runners.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Central YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 42bfcfb6-2e2d-4d1d-8a19-dbe427db613b
📒 Files selected for processing (2)
.github/workflows/execute-all-notebooks.yml.github/workflows/execute-kfp-localrunners.yml
Fixes this error: `Node 20 is being deprecated. This workflow is running with Node 24 by default. If you need to temporarily use Node 20, you can set the ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true environment variable. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/ Run machulav/ec2-github-runner@a6dbcef Error: GitHub Registration Token receiving error Error: HttpError: Bad credentials - https://docs.github.com/rest Error: Bad credentials - https://docs.github.com/rest` because the previous versoin only supports up to Node.js 20 Signed-off-by: Courtney Pacheco <6019922+courtneypacheco@users.noreply.github.com>
9a36611 to
7aa6c8a
Compare
|
🎉 Auto-merged successfully! ✅ All reviewers approved: 1 Approved by: |
Description
Fixes this error:
because the previous version only supports up to Node.js 20, but this new version (2.6.1) does: https://github.com/machulav/ec2-github-runner/releases/tag/v2.6.0
How Has This Been Tested?
Merge criteria:
Summary by CodeRabbit