style: Add per-tab-page class to LoadedTabPage for easier per-tab styling#1947
style: Add per-tab-page class to LoadedTabPage for easier per-tab styling#1947xitij2000 wants to merge 1 commit into
Conversation
|
Thanks for the pull request, @xitij2000! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1947 +/- ##
=======================================
Coverage 91.46% 91.46%
=======================================
Files 351 351
Lines 5820 5820
Branches 1390 1393 +3
=======================================
Hits 5323 5323
Misses 478 478
Partials 19 19 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
Adds a dynamic CSS class to
LoadedTabPage, so each course tab page (e.g. outline, progress, dates, discussion) gets a unique, predictable class name that can be targeted for tab-specific styling.Description
Without the changes in this PR it difficult to apply styles scoped to a single tab (for example, adjusting heading colors only on the Progress tab) without resorting to fragile selectors based on content or position.
This change appends the active tab's slug as a class allowing theme authors to target specific tab pages.