E0d/i18n fixes#290
Open
e0d wants to merge 4 commits into
Open
Conversation
added 4 commits
April 11, 2025 15:47
This commit fixes an internationalization issue in the FileMetaDisplay component by replacing the hardcoded 'Unknown' string with a proper internationalized message. The change: 1. Adds a new message definition in messages.js for unknown file size 2. Updates the FileMetaDisplay component to use FormattedMessage 3. Ensures consistent use of i18n patterns across the application This helps ensure proper translation of all user-facing text in the application.
This commit adds proper internationalization to the 'Past due\!' message in the ProgressStep component by: 1. Adding a new message definition in ProgressBar/messages.js for the past due warning 2. Importing FormattedMessage and messages in the ProgressStep component 3. Replacing the hardcoded string with the internationalized message This ensures the past due warning can be properly translated to different languages.
This commit adds proper internationalization to the title in the StudioViewTitle component by: 1. Adding a new message definition for blockTitle in the studio view messages file 2. Using formatMessage with the title as a parameter instead of directly rendering it This change ensures the block title can be properly translated and follows the project's internationalization standards.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #290 +/- ##
=======================================
Coverage 89.29% 89.29%
=======================================
Files 143 143
Lines 2205 2205
Branches 476 476
=======================================
Hits 1969 1969
Misses 222 222
Partials 14 14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e0d
added
the
create-sandbox
kdmccormick
removed
the
create-sandbox
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposing a few i18n improvements.