feat: ship sign in / register in anonymous header menu by default#263
Merged
Conversation
The header.anonymousMenu.v1 slot was only populated by the dev-only devUserApp, so any non-dev site config produced an empty AnonymousMenu wrapper. Register LoginButton and RegisterButton on headerApp directly and drop devUserApp. Restyle to match frontend-component-header's treatment: Sign In as a text link, Register as outline-primary. Co-Authored-By: Claude <noreply@anthropic.com>
arbrandes
force-pushed
the
arbrandes/anonymous-menu
branch
from
fa4f2f4 to
ab44443
Compare
Contributor
|
The image @diana-villalvazo-wgu posted on slack 
shows "Sign in" as |
Contributor
Author
|
@brian-smith-tcril, @diana-villalvazo-wgu, it's intentional. We're going with what frontend-app-catalog - the most modern MFE - does with the header. |
diana-villalvazo-wgu
approved these changes
May 14, 2026
brian-smith-tcril
approved these changes
May 14, 2026
Contributor
brian-smith-tcril
left a comment
brian-smith-tcril
left a comment
There was a problem hiding this comment.
We're going with what frontend-app-catalog - the most modern MFE - does with the header.
Makes sense. That's the one that people are supposed to see when logged out (as opposed to being redirected to authn), so matching that is perfect!
jesusbalderramawgu
approved these changes
May 14, 2026
|
🎉 This PR is included in version 1.0.0-alpha.48 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #264.
The anonymous header menu wraps an inner slot whose only registrant was a dev-only
devUserApp, so any non-dev site configuration produced an emptyAnonymousMenushell with no visible buttons. This movesLoginButtonandRegisterButtonregistration ontoheaderAppso anonymous users see sign in / register out of the box, and removes the now-redundantdevUserApp. The buttons are also restyled to matchfrontend-component-header'sDesktopLoggedOutItems: Sign In as a text link, Register as outline-primary.LLM usage notice
Built with assistance from Claude.