Skip to content

fix backfill dependencies logrecord#529

Merged
ormsbee merged 1 commit intoopenedx:mainfrom
ormsbee:fix-backfill-dependencies-logrecord
Apr 1, 2026
Merged

fix backfill dependencies logrecord#529
ormsbee merged 1 commit intoopenedx:mainfrom
ormsbee:fix-backfill-dependencies-logrecord

Conversation

@ormsbee
Copy link
Copy Markdown
Contributor

@ormsbee ormsbee commented Apr 1, 2026

This migration used to use the current models, which have a "log_record"
property in order to normalize things more between the Draft and
Published models, but this is not present in the historical models that
this migration was shifted to.

This fix uses the current Published/Draft verisons where that was
equivalent to checking the log records, and explicitly switches between
draft_log_record and publish_log_record in the places where we need to.

Increments version to 0.38.2

Copy link
Copy Markdown
Member

@kdmccormick kdmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhhh I get it now.

@kdmccormick
Copy link
Copy Markdown
Member

kdmccormick commented Apr 1, 2026

version bump? nevermind, I read the diff too fast, LGTM

This migration used to use the current models, which have a "log_record"
property in order to normalize things more between the Draft and
Published models, but this is not present in the historical models that
this migration was shifted to.

This fix uses the current Published/Draft verisons where that was
equivalent to checking the log records, and explicitly switches between
draft_log_record and publish_log_record in the places where we need to.

Increments version to 0.38.2
@ormsbee ormsbee force-pushed the fix-backfill-dependencies-logrecord branch from cbf1155 to 324b677 Compare April 1, 2026 18:56
@ormsbee
Copy link
Copy Markdown
Contributor Author

ormsbee commented Apr 1, 2026

version bump?

Oops. Pushed that up. Thank you.

@ormsbee ormsbee merged commit 4c1a9f1 into openedx:main Apr 1, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants