Long overdue cleanup#241
Open
bmtcril wants to merge 10 commits into
Open
Conversation
Some long overdue cleanup: - Allow env vars to override db settings to reduce likelihood of sensitive values getting committeed to source control - Make abstract classes ABC - Initialize course config mutables in init - Fix test warning about POST being async mocked
Previously we string concatenated inserts, this is probably faster but definitely tidier.
Claude Opus 4.7 was used to add missing type hints
Also makes lms_url configurable, which is a first step towards using real course content for these tests.
Also fixes some random urwid typing issues First pass new docstrings were created by Claude Opus 4.7
Uncovered & fixed some bugs with reusing classes that don't happen in normal use but are good to fix. Claude Opus 4.7 handled the bulk of the new tests
Previously some legitimate errors could be swallowed, this tightens things up and clarifies some logging.
We've run into issues in the past with logs growing to fill huge amounts of disk, this limits that.
saraburns1
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No new functionality, a few minor bug fixes found in testing.
Bugs fixed were around declaring mutable types as class vars instead of on init, which doesn't matter in normal use when the classes are singletons, but breaks testing when classes are reused.
Closes #7
Claude Opus 4.7 was used for doc updates, test updates, adding missing type hints, and other small tasks.