fix: update static_replace import to work with lilac.#92
Closed
johanseto wants to merge 1 commit into
Closed
Conversation
Update static_replace import for lilac.
0aad2b8 to
eef5532
Compare
Author
|
Hi actually this PR is failing one test, but if you see the error it is not a thing I can control: https://app.circleci.com/pipelines/github/edx-solutions/xblock-image-explorer/155/workflows/cc54e07d-3ea9-4322-ad01-030b81a8744a/jobs/315?invite=true#step-103-133. Besides this PR make a very small change. |
Member
|
No longer needed after #228. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes a little fix to the xblock in order to be used in lilac versions.
Change the static_replace import for lilac in
image_explorer.pyin order to be updated with lilac version importsand avoid DeprecatedEdxPlatformImportError.
error: