-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Feature/colorblind mode #4150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
evanpelle
merged 9 commits into
openfrontio:main
from
noahschmal:feature/colorblind-mode
Jun 11, 2026
Merged
Feature/colorblind mode #4150
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
e20a583
Add colorblind mode setting (toggle + wiring, no color changes yet)
noahschmal 8b66d08
Apply colorblind-safe colors when colorblind mode is enabled
noahschmal 92f94b4
Refactor theme system into a BaseTheme abstract class
noahschmal f2451c7
Tune colorblind theme: distinct borders, CVD terrain, stronger tints
noahschmal 2d2c8df
Address review: docstrings, exhaustive terrain switch, colorblind test
noahschmal 9855a27
Drop impossible null return from selectDistinctColorIndex
noahschmal f163443
Add colorblind toggle to the in-game graphics settings
noahschmal 7f2a14e
Recolor territories live when colorblind mode is toggled in-game
noahschmal 58bb08c
Drop removed Lake terrain case from ColorblindTheme
noahschmal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should make sure it takes effect immediately or people will think the setting is broken. Or we can also remove it from this modal for now. in the future we can add it back and have it take effect immediately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I had that commit staged to make it take effect immediately, but had forgotten to push it. It's part of the PR now.