Add Titan map with random spawn nations - along new Cosmic map category#4183
Add Titan map with random spawn nations - along new Cosmic map category#4183RickD004 wants to merge 6 commits into
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughAdds Titan as a new playable map with assets and manifest, registers it in the map generator and playlist, updates GameMapType and mapCategories (introducing cosmic), adds translations and credits, and inserts a new country entry for flags. ChangesTitan Map and Cosmic Category
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@map-generator/assets/maps/titan/info.json`:
- Line 6: The "flag" value for titan is set to "Purple Flag" in
map-generator/assets/maps/titan/info.json (and
resources/maps/titan/manifest.json) but no matching resources/flags/Purple
Flag.svg exists; either add an SVG file named exactly "Purple Flag.svg" to
resources/flags/ or change the "flag" value in info.json/manifest.json to the
name of an existing SVG (matching the client URL pattern
/flags/${nation.flag}.svg) so the client will load a valid flag asset.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 149a211a-d6b0-4e06-abc3-49c9826b4012
⛔ Files ignored due to path filters (4)
map-generator/assets/maps/titan/image.pngis excluded by!**/*.pngresources/maps/titan/map.binis excluded by!**/*.binresources/maps/titan/map16x.binis excluded by!**/*.binresources/maps/titan/map4x.binis excluded by!**/*.bin
📒 Files selected for processing (8)
CREDITS.mdmap-generator/assets/maps/titan/info.jsonmap-generator/main.goresources/lang/en.jsonresources/maps/titan/manifest.jsonresources/maps/titan/thumbnail.webpsrc/core/game/Game.tssrc/server/MapPlaylist.ts
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/core/game/Game.ts`:
- Line 189: The PR adds HongKong to the GameMapType enum (symbol: GameMapType)
and to mapCategories.regional but the PR description mentions Titan + cosmic
which doesn't match this change; update the PR description to explicitly state
that HongKong was added and that map consistency is satisfied (referencing
map-generator/main.go "hongkong", src/server/MapPlaylist.ts entry, assets under
map-generator/assets/maps/hongkong, resources/maps/hongkong files, and
resources/lang/en.json "hongkong"), or if HongKong was not intended, remove it
from GameMapType and mapCategories.regional and adjust tests
(tests/MapConsistency.test.ts) accordingly so the PR scope and code changes are
consistent.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: de0420e9-8efc-4c90-8bad-1478a87c12b9
📒 Files selected for processing (4)
map-generator/main.goresources/lang/en.jsonsrc/core/game/Game.tssrc/server/MapPlaylist.ts
✅ Files skipped from review due to trivial changes (1)
- resources/lang/en.json
🚧 Files skipped from review as they are similar to previous changes (2)
- map-generator/main.go
- src/server/MapPlaylist.ts
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@resources/lang/en.json`:
- Line 618: The JSON entry for the "hongkong" key in resources/lang/en.json is
missing a trailing comma which breaks JSON syntax; update the "hongkong": "Hong
Kong" line to include a trailing comma so it becomes a properly separated item
in the object (i.e., add a comma after the value for the "hongkong" key).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 6e6cf1d4-7e86-4397-8be9-3f4d5e0b59d8
📒 Files selected for processing (4)
map-generator/main.goresources/lang/en.jsonsrc/core/game/Game.tssrc/server/MapPlaylist.ts
🚧 Files skipped from review as they are similar to previous changes (3)
- src/server/MapPlaylist.ts
- map-generator/main.go
- src/core/game/Game.ts
|
@coderabbitai approve |
✅ Action performedComments resolved and changes approved. |
Resolves #4182
Description:
Adds "Titan" (real moon of Saturn with methane seas) map . Uses new random spawn nation feature by FloPinguin. #4156
Also adds new Cosmic map category. The "Other" map category has become a wastebasket of unrelated maps, and with increasing number of maps, i think its a good addition to have better categories for these maps.
I figured these 2 changes should go together since im adding a cosmic map, and a cosmic category.
proof of nations spawning randomly and how the cosmic category looks in the menu:
titan_teaser-ezgif.com-resize-video.mp4
Please complete the following:
Please put your Discord username so you can be contacted if a bug or regression is found:
tri.star1011