Version and OpenHAB compatibility check#77
Open
diijkstra wants to merge 1 commit intoopenhab-scripters:masterfrom
diijkstra:master
Open
Version and OpenHAB compatibility check#77diijkstra wants to merge 1 commit intoopenhab-scripters:masterfrom diijkstra:master
diijkstra wants to merge 1 commit intoopenhab-scripters:masterfrom
diijkstra:master
Conversation
Warns on startup if OpenHAB version is not supported by current release. Prints nice version number on startup. Issue #71
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warns on startup if OpenHAB version is not supported by current release and prints nice version number on startup.
My take on some stuff from Issue #71. Version number probably should be generated from something, but as we don't have build nor test stages lets hard code it for now.
Number 1.0.0a should conform to PEP 440 and indicates alpha release, probably should be bumped just on release date.
If this will conflict with 2.7.1 changes, feel free to reject