Skip to content

refactor(core): select discovery backend from configured type#718

Merged
dsx137 merged 2 commits into
openimsdk:v1.8.4-patchfrom
dsx137:v1.8.4-patch
Jul 22, 2026
Merged

refactor(core): select discovery backend from configured type#718
dsx137 merged 2 commits into
openimsdk:v1.8.4-patchfrom
dsx137:v1.8.4-patch

Conversation

@dsx137

@dsx137 dsx137 commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

🅰 Please add the issue ID after "Fixes #"

Fixes #676

@pull-request-size pull-request-size Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 21, 2026
@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (1724eba) to head (60d2030).
⚠️ Report is 2 commits behind head on v1.8.4-patch.

Files with missing lines Patch % Lines
pkg/common/kdisc/discoveryregister.go 0.00% 16 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           v1.8.4-patch    #718   +/-   ##
============================================
  Coverage          0.00%   0.00%           
============================================
  Files               110     110           
  Lines             12005   12017   +12     
============================================
- Misses            12005   12017   +12     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dsx137
dsx137 merged commit 701677c into openimsdk:v1.8.4-patch Jul 22, 2026
4 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants