Skip to content

Correction for Issue 177 (177_Mistakes-in-description-in-STL-Manual-18.6.2-("Operators-with-complexity-weight-of-1"),-W_shl_sat_l())#178

Open
MarkusMultrus wants to merge 2 commits into
openitu:devfrom
MarkusMultrus:177_Mistakes-in-description-in-STL-Manual-18.6.2-("Operators-with-complexity-weight-of-1"),-W_shl_sat_l()

Hidden character warning

The head ref may contain hidden characters: "177_Mistakes-in-description-in-STL-Manual-18.6.2-("Operators-with-complexity-weight-of-1"),-W_shl_sat_l()"
Open

Correction for Issue 177 (177_Mistakes-in-description-in-STL-Manual-18.6.2-("Operators-with-complexity-weight-of-1"),-W_shl_sat_l())#178
MarkusMultrus wants to merge 2 commits into
openitu:devfrom
MarkusMultrus:177_Mistakes-in-description-in-STL-Manual-18.6.2-("Operators-with-complexity-weight-of-1"),-W_shl_sat_l()

Conversation

@MarkusMultrus
Copy link
Copy Markdown

@MarkusMultrus MarkusMultrus commented Jun 29, 2025

Correct Mistakes in description in STL Manual 18.6.2 ("Operators with complexity weight of 1"), W_shl_sat_l().

This PR:

@ludomal
Copy link
Copy Markdown
Member

ludomal commented May 29, 2026

@MarkusMultrus, good catch!

While reviewing this, I noticed several additional errors in the same section of basop.tex that follow the same pattern (wrong/inconsistent parameter names). Listing them here in case you'd like to include them in this PR:

W_mult_16_16 - extra parameter (W_acc)

W_sat_l - text refers to W_v1, should be W_var1 instead

W_sat_m - same issue, should be W_var1

CL_shl - text refers to L_shift_val but var2 is declared

Mpy_32_32 - Same issue, the parameter name does not match the text

Happy to open a separate issue/PR for these if you prefer.

@MarkusMultrus
Copy link
Copy Markdown
Author

@ludomal: I've hopefully now also addressed the remaining issues and also verified that for everything I've touched the variable naming is consistent (i.e. var for 16 bit variables, L_var for 32 bit variables and W_var for 64 bit etc.).

@ludomal ludomal changed the title Corretion for Issue 177 (177_Mistakes-in-description-in-STL-Manual-18.6.2-("Operators-with-complexity-weight-of-1"),-W_shl_sat_l()) Correction for Issue 177 (177_Mistakes-in-description-in-STL-Manual-18.6.2-("Operators-with-complexity-weight-of-1"),-W_shl_sat_l()) May 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mistakes in description in STL Manual 18.6.2 ("Operators with complexity weight of 1"), W_shl_sat_l()

3 participants