Skip to content

8365623: test/jdk/sun/security/pkcs11/tls/ tests skipped without skip exception#4413

Open
sendaoYan wants to merge 1 commit into
openjdk:masterfrom
openjdk-bots:backport-sendaoYan-da55a565-master
Open

8365623: test/jdk/sun/security/pkcs11/tls/ tests skipped without skip exception#4413
sendaoYan wants to merge 1 commit into
openjdk:masterfrom
openjdk-bots:backport-sendaoYan-da55a565-master

Conversation

@sendaoYan

@sendaoYan sendaoYan commented May 6, 2026

Copy link
Copy Markdown
Member

Hi all,

This pull request contains a backport of commit da55a565 from the openjdk/jdk21u-dev repository.

The commit being backported was authored by Goetz Lindenmaier on 21 Apr 2026 and had no reviewers.

Thanks!



Progress

  • JDK-8365623 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Errors

 ⚠️ OCA signatory status must be verified
 ⚠️ Pull request body is missing required line: - [x] I confirm that I make this contribution in accordance with the [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).

Issue

  • JDK-8365623: test/jdk/sun/security/pkcs11/tls/ tests skipped without skip exception (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4413/head:pull/4413
$ git checkout pull/4413

Update a local copy of the PR:
$ git checkout pull/4413
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4413/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4413

View PR using the GUI difftool:
$ git pr show -t 4413

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4413.diff

@bridgekeeper

bridgekeeper Bot commented May 6, 2026

Copy link
Copy Markdown

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented May 6, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title Backport da55a56513c7b8503dc1c01c3e6ac9b524525243 8365623: test/jdk/sun/security/pkcs11/tls/ tests skipped without skip exception May 6, 2026
@openjdk

openjdk Bot commented May 6, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels May 6, 2026
@sendaoYan

sendaoYan commented May 6, 2026

Copy link
Copy Markdown
Member Author

/approval request Clean backport to make test throw SkippedException when nsslib not available. Change has been verified by run all the touched tests on linux-x64. Test-fix only, no risk.

Touched tests:

test/jdk/sun/security/pkcs11/tls/TestKeyMaterial.java
test/jdk/sun/security/pkcs11/tls/TestKeyMaterialChaCha20.java
test/jdk/sun/security/pkcs11/tls/TestMasterSecret.java
test/jdk/sun/security/pkcs11/tls/TestPRF.java
test/jdk/sun/security/pkcs11/tls/TestPremaster.java
test/jdk/sun/security/pkcs11/tls/tls12/FipsModeTLS12.java

@openjdk

openjdk Bot commented May 6, 2026

Copy link
Copy Markdown

@sendaoYan
8365623: The approval request has been created successfully.

@openjdk openjdk Bot added approval Requires approval; will be removed when approval is received and removed approval Requires approval; will be removed when approval is received labels May 6, 2026
@bridgekeeper bridgekeeper Bot added the oca Needs verification of OCA signatory status label May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required oca Needs verification of OCA signatory status

Development

Successfully merging this pull request may close these issues.

1 participant