8373796: Refactor java/net/httpclient/ThrowingPublishers*.java tests to use JUnit5

[rm-gh-8]

Backporting JDK-8373796: Refactor java/net/httpclient/ThrowingPublishers*.java tests to use JUnit5.

This PR migrates the ThrowingPublishers test family (8 tests + abstract base) from TestNG to JUnit 5, converting data providers to @MethodSource, instance state to static, and the stop-after-first-failure mechanism to a JUnit TestWatcher/BeforeEachCallback extension.

For parity with Oracle JDK. Already backported to 21.

Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:

make test TEST=test/jdk/java/net/httpclient/ThrowingPublishersCustomAfterCancel.java JTREG="OPTIONS=-e:LC_ALL=en_US.UTF-8"
make test TEST=test/jdk/java/net/httpclient/ThrowingPublishersCustomBeforeCancel.java JTREG="OPTIONS=-e:LC_ALL=en_US.UTF-8"
make test TEST=test/jdk/java/net/httpclient/ThrowingPublishersIOAfterCancel.java JTREG="OPTIONS=-e:LC_ALL=en_US.UTF-8"
make test TEST=test/jdk/java/net/httpclient/ThrowingPublishersIOBeforeCancel.java JTREG="OPTIONS=-e:LC_ALL=en_US.UTF-8"
make test TEST=test/jdk/java/net/httpclient/ThrowingPublishersInNextRequest.java JTREG="OPTIONS=-e:LC_ALL=en_US.UTF-8"
make test TEST=test/jdk/java/net/httpclient/ThrowingPublishersInRequest.java JTREG="OPTIONS=-e:LC_ALL=en_US.UTF-8"
make test TEST=test/jdk/java/net/httpclient/ThrowingPublishersInSubscribe.java JTREG="OPTIONS=-e:LC_ALL=en_US.UTF-8"
make test TEST=test/jdk/java/net/httpclient/ThrowingPublishersSanity.java JTREG="OPTIONS=-e:LC_ALL=en_US.UTF-8"

Results:

windows-x64-specific-test.log
windows-x64-specific-2-test.log
windows-x64-specific-3-test.log
windows-x64-specific-4-test.log
windows-x64-specific-5-test.log
windows-x64-specific-6-test.log
windows-x64-specific-7-test.log
windows-x64-specific-8-test.log
linux-x64-specific-test.log
linux-x64-specific-2-test.log
linux-x64-specific-3-test.log
linux-x64-specific-4-test.log
linux-x64-specific-5-test.log
linux-x64-specific-6-test.log
linux-x64-specific-7-test.log
linux-x64-specific-8-test.log
linux-aarch64-specific-test.log
linux-aarch64-specific-2-test.log
linux-aarch64-specific-3-test.log
linux-aarch64-specific-4-test.log
linux-aarch64-specific-5-test.log
linux-aarch64-specific-6-test.log
linux-aarch64-specific-7-test.log
linux-aarch64-specific-8-test.log
macos-aarch64-specific-test.log
macos-aarch64-specific-2-test.log
macos-aarch64-specific-3-test.log
macos-aarch64-specific-4-test.log
macos-aarch64-specific-5-test.log
macos-aarch64-specific-6-test.log
macos-aarch64-specific-7-test.log
macos-aarch64-specific-8-test.log

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8373796 needs maintainer approval

Issue

• JDK-8373796: Refactor java/net/httpclient/ThrowingPublishers*.java tests to use JUnit5 (Sub-task - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4496/head:pull/4496
$ git checkout pull/4496

Update a local copy of the PR:
$ git checkout pull/4496
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4496/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4496

View PR using the GUI difftool:
$ git pr show -t 4496

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4496.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rmesde! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@rm-gh-8 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373796: Refactor java/net/httpclient/ThrowingPublishers*.java tests to use JUnit5

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 32 new commits pushed to the master branch:

• 837a23b: 8300399: EdDSA does not verify when there is no message
• 146f361: 8267617: Certificate's IP x509 NameConstraints raises ArrayIndexOutOfBoundsException
• 342e4d8: Merge
• ... and 29 more: https://git.openjdk.org/jdk17u-dev/compare/454e8e69b1a114be87b6b6d1f1dc3367a52d4f9d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @rm-gh-8 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[rm-gh-8]

/approval request for backport of JDK-8373796: Refactor java/net/httpclient/ThrowingPublishers*.java tests to use JUnit5.

This is a test fix.

Please note that the backport at 9b71cd6 (outside this PR), already merged into the codebase, introduces UTF-8 characters at line 437 of HttpServerAdapters.java. Since Java 17 doesn't include JEP 400, tests involving that file may need: JTREG="OPTIONS=-e:LC_ALL=en_US.UTF-8"

Let me know if you'd like me to open a JBS ticket and create a PR for the fix.

For parity with Oracle JDK. Already backported to 21.

[mlbridge]

Webrevs

• 00: Full (779a4ba8)

[openjdk]

@rm-gh-8
8373796: The approval request has been created successfully.