Skip to content

8386776: [17u] Test test/langtools/jdk/jshell/UndefinedClassTest.java fails on JDK 17 with java.lang.ThreadDeath#4520

Open
rm-gh-8 wants to merge 1 commit into
openjdk:masterfrom
rm-gh-8:JDK-8386776-V17
Open

8386776: [17u] Test test/langtools/jdk/jshell/UndefinedClassTest.java fails on JDK 17 with java.lang.ThreadDeath#4520
rm-gh-8 wants to merge 1 commit into
openjdk:masterfrom
rm-gh-8:JDK-8386776-V17

Conversation

@rm-gh-8

@rm-gh-8 rm-gh-8 commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

The test fails because waitOutput(out, "NotExist") matches the input echo before JShell finishes compiling. The test exits early and Thread.stop() kills the compiler mid-flight. This doesn't manifest in JDK 20+ because of JDK-8289610.

This PR adds waitOutput(out, PROMPT) after matching "NotExist" in order to ensure that JShell has completed compilation.

Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:

make test TEST=test/langtools/jdk/jshell/UndefinedClassTest.java

Results:

windows-x64-specific-test.log
macos-aarch64-specific-test.log
linux-x64-specific-test.log
linux-aarch64-specific-test.log



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8386776 needs maintainer approval

Issue

  • JDK-8386776: [17u] Test test/langtools/jdk/jshell/UndefinedClassTest.java fails on JDK 17 with java.lang.ThreadDeath (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4520/head:pull/4520
$ git checkout pull/4520

Update a local copy of the PR:
$ git checkout pull/4520
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4520/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4520

View PR using the GUI difftool:
$ git pr show -t 4520

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4520.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Jun 16, 2026

Copy link
Copy Markdown

👋 Welcome back rmesde! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jun 16, 2026

Copy link
Copy Markdown

@rm-gh-8 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8386776: [17u] Test test/langtools/jdk/jshell/UndefinedClassTest.java  fails on JDK 17 with java.lang.ThreadDeath

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • d133da2: 8356695: java/lang/StringBuilder/HugeCapacity.java failing with OOME
  • a94ecbe: 8373866: Refactor java/net/httpclient/ThrowingSubscribers*.java tests to use JUnit5
  • eb94d68: 8378878: Refactor java/nio/channels/AsynchronousSocketChannel test to use JUnit

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk Bot changed the title 8386776: [17u] Test test/langtools/jdk/jshell/UndefinedClassTest.java… 8386776: [17u] Test test/langtools/jdk/jshell/UndefinedClassTest.java fails on JDK 17 with java.lang.ThreadDeath Jun 16, 2026
@rm-gh-8 rm-gh-8 marked this pull request as ready for review June 16, 2026 16:32
@openjdk openjdk Bot added the rfr Pull request is ready for review label Jun 16, 2026
@mlbridge

mlbridge Bot commented Jun 16, 2026

Copy link
Copy Markdown

Webrevs

@openjdk

openjdk Bot commented Jun 16, 2026

Copy link
Copy Markdown

⚠️ @rm-gh-8 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk

openjdk Bot commented Jun 16, 2026

Copy link
Copy Markdown

@rm-gh-8 usage: /approval [<id>] (request|cancel) [<text>]

@rm-gh-8

rm-gh-8 commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

/approval 8386776 request This is a test fix.

@openjdk

openjdk Bot commented Jun 16, 2026

Copy link
Copy Markdown

@rm-gh-8
8386776: The approval request has been created successfully.

@openjdk openjdk Bot added the approval Requires approval; will be removed when approval is received label Jun 16, 2026
@GoeLin

GoeLin commented Jun 19, 2026

Copy link
Copy Markdown
Member

I verified this fixes the issue in out CR.

@openjdk openjdk Bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Jun 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

3 participants