8386776: [17u] Test test/langtools/jdk/jshell/UndefinedClassTest.java fails on JDK 17 with java.lang.ThreadDeath#4520
8386776: [17u] Test test/langtools/jdk/jshell/UndefinedClassTest.java fails on JDK 17 with java.lang.ThreadDeath#4520rm-gh-8 wants to merge 1 commit into
Conversation
… fails on JDK 17 with java.lang.ThreadDeath
|
👋 Welcome back rmesde! A progress list of the required criteria for merging this PR into |
|
@rm-gh-8 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
|
|
@rm-gh-8 usage: |
|
/approval 8386776 request This is a test fix. |
|
I verified this fixes the issue in out CR. |
The test fails because waitOutput(out, "NotExist") matches the input echo before JShell finishes compiling. The test exits early and Thread.stop() kills the compiler mid-flight. This doesn't manifest in JDK 20+ because of JDK-8289610.
This PR adds waitOutput(out, PROMPT) after matching "NotExist" in order to ensure that JShell has completed compilation.
Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:
make test TEST=test/langtools/jdk/jshell/UndefinedClassTest.java
Results:
windows-x64-specific-test.log
macos-aarch64-specific-test.log
linux-x64-specific-test.log
linux-aarch64-specific-test.log
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4520/head:pull/4520$ git checkout pull/4520Update a local copy of the PR:
$ git checkout pull/4520$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4520/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4520View PR using the GUI difftool:
$ git pr show -t 4520Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4520.diff
Using Webrev
Link to Webrev Comment