8343342: java/io/File/GetXSpace.java fails on Windows with CD-ROM drive#4524
8343342: java/io/File/GetXSpace.java fails on Windows with CD-ROM drive#4524rm-gh-8 wants to merge 1 commit into
Conversation
|
👋 Welcome back rmesde! A progress list of the required criteria for merging this PR into |
|
@rm-gh-8 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request for backport of JDK-8343342: java/io/File/GetXSpace.java fails on Windows with CD-ROM drive. This is a test fix. For parity with Oracle JDK. Already backported to 21. |
Backporting JDK-8343342: java/io/File/GetXSpace.java fails on Windows with CD-ROM drive.
This PR improves the filesystem space checking logic for the test.
For parity with Oracle JDK. Already backported to 21.
Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:
make test TEST=test/jdk/java/io/File/GetXSpace.java
Results:
windows-x64-specific-test.log
macos-aarch64-specific-test.log
linux-x64-specific-test.log
linux-aarch64-specific-test.log
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4524/head:pull/4524$ git checkout pull/4524Update a local copy of the PR:
$ git checkout pull/4524$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4524/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4524View PR using the GUI difftool:
$ git pr show -t 4524Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4524.diff
Using Webrev
Link to Webrev Comment