Skip to content

8343342: java/io/File/GetXSpace.java fails on Windows with CD-ROM drive#4524

Open
rm-gh-8 wants to merge 1 commit into
openjdk:masterfrom
rm-gh-8:JDK-8343342-V17
Open

8343342: java/io/File/GetXSpace.java fails on Windows with CD-ROM drive#4524
rm-gh-8 wants to merge 1 commit into
openjdk:masterfrom
rm-gh-8:JDK-8343342-V17

Conversation

@rm-gh-8

@rm-gh-8 rm-gh-8 commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Backporting JDK-8343342: java/io/File/GetXSpace.java fails on Windows with CD-ROM drive.

This PR improves the filesystem space checking logic for the test.

For parity with Oracle JDK. Already backported to 21.

Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:

make test TEST=test/jdk/java/io/File/GetXSpace.java

Results:

windows-x64-specific-test.log
macos-aarch64-specific-test.log
linux-x64-specific-test.log
linux-aarch64-specific-test.log



Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8343342 needs maintainer approval

Issue

  • JDK-8343342: java/io/File/GetXSpace.java fails on Windows with CD-ROM drive (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4524/head:pull/4524
$ git checkout pull/4524

Update a local copy of the PR:
$ git checkout pull/4524
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4524/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4524

View PR using the GUI difftool:
$ git pr show -t 4524

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4524.diff

Using Webrev

Link to Webrev Comment

@rm-gh-8 rm-gh-8 marked this pull request as ready for review June 17, 2026 14:00
@bridgekeeper

bridgekeeper Bot commented Jun 17, 2026

Copy link
Copy Markdown

👋 Welcome back rmesde! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jun 17, 2026

Copy link
Copy Markdown

@rm-gh-8 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8343342: java/io/File/GetXSpace.java fails on Windows with CD-ROM drive

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk Bot changed the title Backport 983307e45f14f082fb17f318a2814680cbe99a93 8343342: java/io/File/GetXSpace.java fails on Windows with CD-ROM drive Jun 17, 2026
@openjdk

openjdk Bot commented Jun 17, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jun 17, 2026
@openjdk

openjdk Bot commented Jun 17, 2026

Copy link
Copy Markdown

⚠️ @rm-gh-8 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Jun 17, 2026
@mlbridge

mlbridge Bot commented Jun 17, 2026

Copy link
Copy Markdown

Webrevs

@rm-gh-8

rm-gh-8 commented Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

/approval request for backport of JDK-8343342: java/io/File/GetXSpace.java fails on Windows with CD-ROM drive.

This is a test fix.

For parity with Oracle JDK. Already backported to 21.

@openjdk

openjdk Bot commented Jun 17, 2026

Copy link
Copy Markdown

@rm-gh-8
8343342: The approval request has been created successfully.

@openjdk openjdk Bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant