Skip to content

8338587: Internal XOF Methods for SHAKE128 and SHAKE256#4532

Open
GoeLin wants to merge 1 commit into
openjdk:pr/4531from
GoeLin:gbp_8338587
Open

8338587: Internal XOF Methods for SHAKE128 and SHAKE256#4532
GoeLin wants to merge 1 commit into
openjdk:pr/4531from
GoeLin:gbp_8338587

Conversation

@GoeLin

@GoeLin GoeLin commented Jun 19, 2026

Copy link
Copy Markdown
Member

Backport of the change in 21.

Resolved two copyrights.

Will make this depend on the push to 21 once available. Will probably be clean.



Progress

  • Change must not contain extraneous whitespace
  • JDK-8338587 needs maintainer approval
  • Commit message must refer to an issue

Integration blocker

 ⚠️ Dependency #4531 must be integrated first

Issue

  • JDK-8338587: Internal XOF Methods for SHAKE128 and SHAKE256 (Enhancement - P3 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4532/head:pull/4532
$ git checkout pull/4532

Update a local copy of the PR:
$ git checkout pull/4532
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4532/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4532

View PR using the GUI difftool:
$ git pr show -t 4532

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4532.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Jun 19, 2026

Copy link
Copy Markdown

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jun 19, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Jun 19, 2026
@mlbridge

mlbridge Bot commented Jun 19, 2026

Copy link
Copy Markdown

Webrevs

@GoeLin GoeLin changed the base branch from master to pr/4531 June 19, 2026 12:16
@GoeLin GoeLin changed the title 8338587 from 21 backport 1bf953eef070fa693044b42bc3861ad5ad22d384 Jun 20, 2026
@GoeLin

GoeLin commented Jun 20, 2026

Copy link
Copy Markdown
Member Author

The change was pushed to 21, I updated the title. Hopfully recognized as clean now :)

@openjdk openjdk Bot changed the title backport 1bf953eef070fa693044b42bc3861ad5ad22d384 8338587: Internal XOF Methods for SHAKE128 and SHAKE256 Jun 20, 2026
@openjdk

openjdk Bot commented Jun 20, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required approval Requires approval; will be removed when approval is received labels Jun 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant