Skip to content

8386991: Insets are incorrectly set in newer Gnome versions#4533

Open
satyenme wants to merge 1 commit into
openjdk:masterfrom
satyenme:8305825-fix
Open

8386991: Insets are incorrectly set in newer Gnome versions#4533
satyenme wants to merge 1 commit into
openjdk:masterfrom
satyenme:8305825-fix

Conversation

@satyenme

@satyenme satyenme commented Jun 19, 2026

Copy link
Copy Markdown

The original backport of JDK-8305825 missed changes to src/java.desktop/unix/classes/sun/awt/X11/XDecoratedPeer.java for JDK 17 and below. This leads to the SimpleTest.java test included on that JBS issue continuing to fail on Ubuntu 24.04.

This patch adds in the relevant code from the original JDK-8305825 patch to ensure the test passes and windows are rendered with the correct insets and size.



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8386991 needs maintainer approval

Issue

  • JDK-8386991: Insets are incorrectly set in newer Gnome versions (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4533/head:pull/4533
$ git checkout pull/4533

Update a local copy of the PR:
$ git checkout pull/4533
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4533/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4533

View PR using the GUI difftool:
$ git pr show -t 4533

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4533.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Jun 19, 2026

Copy link
Copy Markdown

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jun 19, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Jun 19, 2026
@mlbridge

mlbridge Bot commented Jun 19, 2026

Copy link
Copy Markdown

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant