8373557: Remove stale comments after JDK-8372584#622
Open
mmm-choi wants to merge 3 commits into
Open
Conversation
|
👋 Welcome back mmm-choi! A progress list of the required criteria for merging this PR into |
5 tasks
|
❗ This change is not yet ready to be integrated. |
5 tasks
|
This backport pull request has now been updated with issue from the original commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of JDK-8373557 (dc1b0b5f) to 25u.
This is the third of three related backports and must be applied after JDK-8372584 (#621):
supports_fast_thread_cpu_timedual-path logic. This is the prerequisite./procparsing withclock_gettime. This is the optimization.It removes comments in
os_linux.cppandos.hppthat became stale/incorrect after JDK-8372584 (for example the "very slow /proc fs" description, which no longer reflects the implementation). Included for parity with mainline so 25u does not carry misleading comments.Clean backport
This applied cleanly with no conflicts. The change is comment-only.
Testing
Built
releaseon linux-x86_64 and linux-aarch64 (comment-only change). Verified the full 3-commit stack against the thread-CPU-time test set (see the JDK-8372584 PR #621) and all pass.Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/622/head:pull/622$ git checkout pull/622Update a local copy of the PR:
$ git checkout pull/622$ git pull https://git.openjdk.org/jdk25u-dev.git pull/622/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 622View PR using the GUI difftool:
$ git pr show -t 622Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/622.diff
Using Webrev
Link to Webrev Comment