8162545: Mac build failure

[zzambers]

Backport fixing compilation error on newer gcc (14.2.0), found when testing other PR:

/starfive/jdk8u-dev/jdk/src/share/native/sun/awt/image/jpeg/imageioJPEG.c: In function 'Java_com_sun_imageio_plugins_jpeg_JPEGImageWriter_writeImage':
/starfive/jdk8u-dev/jdk/src/share/native/sun/awt/image/jpeg/imageioJPEG.c:2857:19: error: passing argument 1 of 'freeArray' from incompatible pointer type [-Wincompatible-pointer-types]
 2857 |         freeArray(scale, numBands);
      |                   ^~~~~
      |                   |
      |                   UINT8 ** {aka unsigned char **}

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• JDK-8162545 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8162545: Mac build failure (Bug - P1 - Approved)

Reviewers

• Severin Gehwolf (@jerboaa - Reviewer)
• Andrew John Hughes (@gnu-andrew - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/795/head:pull/795
$ git checkout pull/795

Update a local copy of the PR:
$ git checkout pull/795
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/795/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 795

View PR using the GUI difftool:
$ git pr show -t 795

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/795.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@zzambers This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8162545: Mac build failure

Reviewed-by: sgehwolf, andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (fe148488)

[jerboaa]

Looks OK to me.

[openjdk]

⚠️ @zzambers This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[zzambers]

/approval request backport fixing compilation error on newer gcc, trivial change, small risk, tested

[openjdk]

@zzambers
8162545: The approval request has been created successfully.

[gnu-andrew]

Yes, I hit this too with GCC 14 and was going to propose it. The bug subject is deceptive as it's not Mac-specific. The types are obviously wrong and have been wrong since OpenJDK began.

Your patch matches mine.

[gnu-andrew]

/approve yes

[openjdk]

@gnu-andrew
8162545: The approval request has been approved.