Skip to content

8321489: Update LCMS to 2.16#798

Open
alexeybakhtin wants to merge 1 commit into
openjdk:masterfrom
alexeybakhtin:JDK-8321489
Open

8321489: Update LCMS to 2.16#798
alexeybakhtin wants to merge 1 commit into
openjdk:masterfrom
alexeybakhtin:JDK-8321489

Conversation

@alexeybakhtin
Copy link
Copy Markdown
Contributor

@alexeybakhtin alexeybakhtin commented May 19, 2026

Clean backport of LCMS to 2.16



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8321489 needs maintainer approval

Issue

  • JDK-8321489: Update LCMS to 2.16 (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/798/head:pull/798
$ git checkout pull/798

Update a local copy of the PR:
$ git checkout pull/798
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/798/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 798

View PR using the GUI difftool:
$ git pr show -t 798

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/798.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented May 19, 2026

👋 Welcome back abakhtin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 19, 2026

@alexeybakhtin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8321489: Update LCMS to 2.16

Reviewed-by: andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk Bot changed the title Backport dc7d3b182d226253ca246dd854c85c4dd964f10e 8321489: Update LCMS to 2.16 May 19, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 19, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels May 19, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented May 19, 2026

Webrevs

Copy link
Copy Markdown
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't clean, but the lcms.md changes seem to have been correctly adapted to THIRD_PARTY_README.

What testing was done? Do the sun.java2d.cmm tests look good?

@alexeybakhtin
Copy link
Copy Markdown
Contributor Author

What testing was done? Do the sun.java2d.cmm tests look good?

Thank you for review
I've tested with sun.java2d.cmm tests. All passed

Copy link
Copy Markdown
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 20, 2026

⚠️ @alexeybakhtin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk Bot added the approval Requires approval; will be removed when approval is received label May 20, 2026
@jerboaa
Copy link
Copy Markdown
Contributor

jerboaa commented May 21, 2026

/approve yes

@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 21, 2026

@jerboaa
8321489: The approval request has been approved.

@openjdk openjdk Bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

4 participants