8298873: Update IllegalRecordVersion.java for changes to TLS implementation

[jerboaa]

Please review this unclean test-only backport for JDK-8298873. This is in preparation for a backport of JDK-8284047 which in turn is in prep for a crypto roadmap update in OpenJDK 8u. It's unclean because:

• There is no problem list entry in 8u for IllegalRecordVersion.java. It's listed as @ignore instead and that has been since the original introduction of it with JDK-8245681
• I've removed the IllegalRecordVersion.java manually.
• The new test had one usage of var which isn't supported in JDK 8.

Testing

• Ran the new test, HandshakeWithInvalidRecordVersion.java on latest JDK 8u tree which passes and produces the same results as the JDK 11u test.

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8298873 needs maintainer approval
• JDK-8301189 needs maintainer approval

Issues

• JDK-8298873: Update IllegalRecordVersion.java for changes to TLS implementation (Bug - P4 - Requested)
• JDK-8301189: validate-source fails after JDK-8298873 (Bug - P1 - Requested)

Reviewers

• Andrew John Hughes (@gnu-andrew - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/800/head:pull/800
$ git checkout pull/800

Update a local copy of the PR:
$ git checkout pull/800
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/800/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 800

View PR using the GUI difftool:
$ git pr show -t 800

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/800.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issues from the original commit.

[mlbridge]

Webrevs

• 00: Full (6a219d45)

[gnu-andrew]

This was actually added by JDK-8042449 for the old TLS implementation in 2014. It was then removed by JDK-8245653 as part of the TLS v1.3 work and then readded again in JDK-8245681, though I can't see anything in the review thread as to the @ignore being added. In fact, it says "without any modification".

Backport looks good. var change is appropriate and the difference in the two removed files is only this errant @ignore.

[openjdk]

⚠️ @jerboaa This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[jerboaa]

/approval request Please allow this test-only change for OpenJDK 8u. This increases test coverage and helps bring in JDK-8284047 for a test upgrade in preparation for some OpenJDK 8u crypto update changes. Patch is not clean. Reviewed by Andrew Hughes. Risk is low (test only change) and new test passes with the current 8u TLS stack.

[openjdk]

@jerboaa
8298873: The approval request has been created successfully.
8301189: The approval request has been created successfully.