Skip to content

8246330: Add TLS Tests for Legacy ECDSA curves#804

Open
jerboaa wants to merge 2 commits into
openjdk:pr/801from
jerboaa:8246330-legacy-ecdsa-curves-test
Open

8246330: Add TLS Tests for Legacy ECDSA curves#804
jerboaa wants to merge 2 commits into
openjdk:pr/801from
jerboaa:8246330-legacy-ecdsa-curves-test

Conversation

@jerboaa
Copy link
Copy Markdown
Contributor

@jerboaa jerboaa commented May 20, 2026

Another SSL test backport in preparation for JDK-8284047. The patch isn't clean because of a) different paths in JDK 8u and b) because of 8202343: Disable TLS 1.0 and 1.1 done ahead of this backport, and, thus, this patch needs to re-enable those TLS versions. See second commit.

Testing

  • The new DisabledCurve.java test passes. Existing SSL tests continue to pass.

Thoughts?



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8246330 needs maintainer approval

Integration blocker

 ⚠️ Dependency #801 must be integrated first

Issue

  • JDK-8246330: Add TLS Tests for Legacy ECDSA curves (Enhancement - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/804/head:pull/804
$ git checkout pull/804

Update a local copy of the PR:
$ git checkout pull/804
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/804/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 804

View PR using the GUI difftool:
$ git pr show -t 804

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/804.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented May 20, 2026

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into pr/801 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 20, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot added the rfr Pull request is ready for review label May 20, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented May 20, 2026

Webrevs

@jerboaa jerboaa changed the title 8246330 legacy ecdsa curves test Backport 955d9fb554dbc0d12cea90eb85ffefafec9f34d1 May 20, 2026
@openjdk openjdk Bot changed the title Backport 955d9fb554dbc0d12cea90eb85ffefafec9f34d1 8246330: Add TLS Tests for Legacy ECDSA curves May 20, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 20, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added the backport Port of a pull request already in a different code base label May 20, 2026
@jerboaa
Copy link
Copy Markdown
Contributor Author

jerboaa commented May 20, 2026

Test failures seem unrelated (seen elsewhere too):

security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#buypassclass3ca 
security/infra/java/security/cert/CertPathValidator/certification/EmSignRootG2CA.java 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant