feat(fgame): WIP built-in ACL admin system#907
Draft
Crimewavez wants to merge 3 commits into
Draft
Conversation
Use system-provided libsodium instead of vendoring it in-tree. After long reading, as far as I understood this is the way enouraged by official libsodium docs. This keeps security maintenance outside the repo and leaves the dependency reusable for future targets.
Turns out libsodium has no CMakeLists.txt so this was way more painful than expected. Linux and macOS go through autotools, Windows uses the MSVC solution file with a hand-rolled cmake config package. Native CI jobs just use libsodium-dev from apt. Every arch gets its own cached static build so releases don't depend on the user having anything installed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP implementation of: #905 (comment)
Leaving issue for discussions on direction and design. PR made for code review and implementation threads.